Skip to content

Make igbinary_serialize()/igbinary_unserialize() match serialize()/unserialize() again #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-grekas wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Make igbinary_serialize()/igbinary_unserialize() match serialize()/unserialize() again #423

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7828814
Fix use-after-free and leak in igbinary_serialize_array()
nicolas-grekas Sep 29, 2026
2c7c449
Make __sleep() handling match serialize()
nicolas-grekas Sep 29, 2026
704bdf5
Serialize declared properties without building the properties table
nicolas-grekas Sep 29, 2026
634a23b
Count unserialize depth on arrays and objects like unserialize()
nicolas-grekas Sep 29, 2026
4a7b23f
Check class names and formats like unserialize() does
nicolas-grekas Sep 29, 2026
17c60b5
Add the allowed_classes and max_depth options to igbinary_unserialize()
nicolas-grekas Sep 29, 2026
fe9ab06
Let __unserialize() overwrite the defaults of readonly properties
nicolas-grekas Sep 29, 2026
a676614
Don't expose partially unserialized objects on failure
nicolas-grekas Sep 29, 2026
2caeeda
Add missing tests to package.xml
nicolas-grekas Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing tests to package.xml
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Sep 29, 2026
commit 2caeeda73f9e849bd1688a9440a53bd6ca1c0627
16 changes: 16 additions & 0 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ memcached or similar memory based storages for serialized data.</description>
<file name="igbinary_016.phpt" role="test" />
<file name="igbinary_017.phpt" role="test" />
<file name="igbinary_018.phpt" role="test" />
<file name="igbinary_018_php7.phpt" role="test" />
<file name="igbinary_019.phpt" role="test" />
<file name="igbinary_020.phpt" role="test" />
<file name="igbinary_021.phpt" role="test" />
Expand Down Expand Up @@ -179,6 +180,7 @@ memcached or similar memory based storages for serialized data.</description>
<file name="igbinary_063_php72.phpt" role="test" />
<file name="igbinary_064.phpt" role="test" />
<file name="igbinary_065.phpt" role="test" />
<file name="igbinary_065_php7.phpt" role="test" />
<file name="igbinary_066.phpt" role="test" />
<file name="igbinary_067.phpt" role="test" />
<file name="igbinary_068.phpt" role="test" />
Expand All @@ -205,6 +207,8 @@ memcached or similar memory based storages for serialized data.</description>
<file name="igbinary_086.phpt" role="test" />
<file name="igbinary_087.phpt" role="test" />
<file name="igbinary_088.phpt" role="test" />
<file name="igbinary_088_php7.phpt" role="test" />
<file name="igbinary_088_php80.phpt" role="test" />
<file name="igbinary_089.phpt" role="test" />
<file name="igbinary_089_32bit.phpt" role="test" />
<file name="igbinary_090.phpt" role="test" />
Expand All @@ -219,20 +223,32 @@ memcached or similar memory based storages for serialized data.</description>
<file name="igbinary_099.phpt" role="test" />
<file name="igbinary_100.phpt" role="test" />
<file name="igbinary_101.phpt" role="test" />
<file name="igbinary_102.phpt" role="test" />
<file name="igbinary_bug54662.phpt" role="test" />
<file name="igbinary_bug72134.phpt" role="test" />
<file name="igbinary_enums_1.phpt" role="test" />
<file name="igbinary_enums_2.phpt" role="test" />
<file name="igbinary_enums_3.phpt" role="test" />
<file name="igbinary_enums_3_php83.phpt" role="test" />
<file name="igbinary_serialize_deep_nesting.phpt" role="test" />
<file name="igbinary_unserialize_max_depth.phpt" role="test" />
<file name="igbinary_unserialize_max_depth_boundary.phpt" role="test" />
<file name="igbinary_unserialize_options.phpt" role="test" />
<file name="igbinary_unserialize_v1_compatible.phpt" role="test" />
<file name="php82_suppress_dynamic_properties_warning.inc" role="test" />
<file name="serialize_array_ref_reentrancy.phpt" role="test" />
<file name="serialize_declared_properties.phpt" role="test" />
<file name="serialize_object_as_null.phpt" role="test" />
<file name="sleep_mangled_name_clash.phpt" role="test" />
<file name="typed_property_ref_assignment_failure.phpt" role="test" />
<file name="typed_property_ref_overwrite.phpt" role="test" />
<file name="typed_property_ref_overwrite2.phpt" role="test" />
<file name="typed_property_refs.phpt" role="test" />
<file name="typed_property_refs_php74.phpt" role="test" />
<file name="unserialize_class_name_checks.phpt" role="test" />
<file name="unserialize_failure_cleanup.phpt" role="test" />
<file name="unserialize_readonly_default.phpt" role="test" />
<file name="unserialize_serializable_format.phpt" role="test" />
</dir>
</dir>
</contents>
Expand Down