Skip to content

Feature: Ventura LoginItem support - #26

Merged
hazcod merged 2 commits into
masterfrom
fix/ventura
Nov 15, 2022
Merged

hazcod merged 2 commits into
masterfrom
fix/ventura

Conversation

@hazcod

@hazcod hazcod commented Nov 15, 2022

Copy link
Copy Markdown
Owner

No description provided.

Comment thread maclaunch.sh
# for every plist found
while IFS= read -r -d '' plistPath; do

loginItems=$(cat "$plistPath" | grep key | cut -d '>' -f 2 | cut -d '<' -f 1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. SC2002

Comment thread maclaunch.sh

loginItems=$(cat "$plistPath" | grep key | cut -d '>' -f 2 | cut -d '<' -f 1)

for loginItem in ${loginItems[@]}; do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068

@hazcod
hazcod merged commit 04e0d4d into master Nov 15, 2022
Comment thread maclaunch.sh
fi

local launchState=""
for disabledLoginItem in ${disabledLoginItems[@]}; do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant