Skip to content

JS3-Week2-Homework #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haha1906 wants to merge 5 commits into
base: week1
Choose a base branch
from
Open

JS3-Week2-Homework #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69bc51c
JS3-Week2-Homework
haha1906 Sep 24, 2019
0e92d37
JS3-Week2-Homework
haha1906 Sep 24, 2019
d2a83c9
Week2 Homework promise added
haha1906 Sep 25, 2019
f523f30
mistakes with promise errors, kebab-cases, variables names are correc…
haha1906 Sep 26, 2019
5fcd491
Option values aren't added each time, anymore.
haha1906 Sep 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Week2 Homework promise added
  • Loading branch information
@haha1906
haha1906 committed Sep 25, 2019
commit d2a83c9d0dc0d55068e85f2bf5dfd2f423a75e67
34 changes: 19 additions & 15 deletions homework/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,21 @@
'use strict';

{
function fetchJSON(url, cb) {
const xhr = new XMLHttpRequest();
xhr.open('GET', url);
xhr.responseType = 'json';
xhr.onload = () => {
if (xhr.status >= 200 && xhr.status <= 299) {
cb(null, xhr.response);
} else {
cb(new Error(`Network error: ${xhr.status} - ${xhr.statusText}`));
}
};
xhr.onerror = () => cb(new Error('Network request failed'));
xhr.send();
function fetchJSON(url) {
return new Promise((resolve, reject) => {
const xhr = new XMLHttpRequest();
xhr.open('GET', url);
xhr.responseType = 'json';
xhr.onload = () => {
if (xhr.status >= 200 && xhr.status <= 299) {
resolve(xhr.response);
} else {
reject(new Error(`Network error: ${xhr.status} - ${xhr.statusText}`));
}
};
xhr.onerror = () => reject(new Error('Network request failed'));
xhr.send();
});
}

function createAndAppend(name, parent, options = {}) {
Expand Down Expand Up @@ -94,7 +96,8 @@
}

function fetchContributors(url, contributorsContainer) {
fetchJSON(url, (err, conts) => {
const promiseContributor = fetchJSON(url);
promiseContributor.then((conts, err) => {
if (err) {
createAndAppend('div', contributorsContainer, {
text: err.message,
Expand Down Expand Up @@ -135,7 +138,8 @@
}

function main(url) {
fetchJSON(url, (err, repos) => {
const promise = fetchJSON(url);
promise.then((repos, err) => {
const root = document.getElementById('root');
if (err) {
createAndAppend('div', root, {
Expand Down