Skip to content

OneOf inhabitability fixes #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbellenger wants to merge 4 commits into
base: master
Choose a base branch
from
Open

OneOf inhabitability fixes #4458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d02d42
checkpoint
jbellenger Apr 8, 2026
47ef3e5
Merge remote-tracking branch 'upstream/master' into jbellenger-oneof-…
jbellenger Aug 22, 2026
2de6a55
Align input object cycle detection with graphql-js
jbellenger Aug 22, 2026
b616984
Add input object cycle validation benchmarks
jbellenger Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions src/jmh/java/benchmark/InputObjectHasUnbreakableCycleBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
package benchmark;

import graphql.schema.GraphQLSchema;
import graphql.schema.GraphQLTypeVisitor;
import graphql.schema.SchemaTraverser;
import graphql.schema.idl.FastSchemaGenerator;
import graphql.schema.idl.RuntimeWiring;
import graphql.schema.idl.SchemaGenerator;
import graphql.schema.idl.SchemaParser;
import graphql.schema.idl.TypeDefinitionRegistry;
import graphql.schema.validation.InputObjectHasUnbreakableCycle;
import graphql.schema.validation.SchemaValidationError;
import graphql.schema.validation.SchemaValidationErrorCollector;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.annotations.Warmup;
import org.openjdk.jmh.infra.Blackhole;

import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;

/** Measures full-schema traversal with only the input object cycle validator. */
@State(Scope.Thread)
@BenchmarkMode(Mode.AverageTime)
@Warmup(iterations = 2, time = 5)
@Measurement(iterations = 3)
@Fork(2)
@OutputTimeUnit(TimeUnit.MICROSECONDS)
public class InputObjectHasUnbreakableCycleBenchmark {

private GraphQLSchema twoTypeMixedInputCycle;
private GraphQLSchema tenTypeMixedInputCycle;
private GraphQLSchema tenTypeTenFieldsInputCycle;
private GraphQLSchema finiteValuePropagation;
private SchemaTraverser schemaTraverser;
private List<GraphQLTypeVisitor> cycleValidators;
private SchemaValidationErrorCollector errorCollector;
private Map<Class<?>, Object> rootVariables;

@Setup(Level.Trial)
public void setUpSchemas() {
twoTypeMixedInputCycle = loadSchema(
"InputObjectHasUnbreakableCycleBenchmark/twoTypeMixedInputCycle.graphqls"
);
tenTypeMixedInputCycle = loadSchema(
"InputObjectHasUnbreakableCycleBenchmark/tenTypeMixedInputCycle.graphqls"
);
tenTypeTenFieldsInputCycle = loadSchema(
"InputObjectHasUnbreakableCycleBenchmark/tenTypeTenFieldsInputCycle.graphqls"
);
finiteValuePropagation = loadSchema(
"InputObjectHasUnbreakableCycleBenchmark/finiteValuePropagation.graphqls"
);
schemaTraverser = new SchemaTraverser();
}

@Setup(Level.Invocation)
public void setUpInvocation() {
cycleValidators = Collections.singletonList(new InputObjectHasUnbreakableCycle());
errorCollector = new SchemaValidationErrorCollector();
rootVariables = new LinkedHashMap<>();
rootVariables.put(SchemaValidationErrorCollector.class, errorCollector);
}

@Benchmark
public void twoTypeMixedInputCycle(Blackhole blackhole) {
validate(twoTypeMixedInputCycle, blackhole);
}

@Benchmark
public void tenTypeMixedInputCycle(Blackhole blackhole) {
validate(tenTypeMixedInputCycle, blackhole);
}

@Benchmark
public void tenTypeTenFieldsInputCycle(Blackhole blackhole) {
validate(tenTypeTenFieldsInputCycle, blackhole);
}

@Benchmark
public void finiteValuePropagation(Blackhole blackhole) {
validate(finiteValuePropagation, blackhole);
}

private void validate(GraphQLSchema schema, Blackhole blackhole) {
schemaTraverser.depthFirstFullSchema(cycleValidators, schema, rootVariables);
for (SchemaValidationError error : errorCollector.getErrors()) {
blackhole.consume(error);
}
}

private GraphQLSchema loadSchema(String schemaPath) {
String schemaString = BenchmarkUtils.loadResource(schemaPath);
TypeDefinitionRegistry typeRegistry = new SchemaParser().parse(schemaString);
return new FastSchemaGenerator().makeExecutableSchema(
SchemaGenerator.Options.defaultOptions().withValidation(false),
typeRegistry,
RuntimeWiring.MOCKED_WIRING
);
}
}
Loading
Loading