Skip to content

Fix CompletionStageSubscriber race condition, add jcstress tests and CI coverage gate #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 10 commits into from
Mar 6, 2026
Merged

Fix CompletionStageSubscriber race condition, add jcstress tests and CI coverage gate #4296

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cdc892a
Fix race condition in CompletionStageSubscriber.onComplete()
andimarek Mar 6, 2026
7f0bcae
Add jcstress stress tests and CI integration
andimarek Mar 6, 2026
9132b0b
Fix jcstress CI: create build dir before tee
andimarek Mar 6, 2026
4936a15
Fix flaky optional_spec111 TCK multicast test
andimarek Mar 6, 2026
1e316ed
Verify exact set of TestNG TCK skipped tests after each run
andimarek Mar 6, 2026
069d64a
Fix coverage gate to check per-class regressions, not just overall
andimarek Mar 6, 2026
ac6274f
Fix coverage gate false positives and add missing tests
andimarek Mar 6, 2026
460d365
Rename test-summary check to Test Report & Per-Class Coverage Gate
andimarek Mar 6, 2026
1405d45
Exclude identity equals/hashCode from JaCoCo coverage via bytecode an…
andimarek Mar 6, 2026
099b330
Bump Java toolchain from 21 to 25 to match CI
andimarek Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix coverage gate to check per-class regressions, not just overall 
The previous gate only checked overall line/branch/method coverage,
which allowed per-class regressions to pass when offset by improvements
elsewhere. Now fails on any class regressing any metric by >0.05%.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@andimarek @claude
andimarek and claude committed Mar 6, 2026
commit 069d64a4fdbc5aa3d37ffdc4b3805b82c4dbdc33
27 changes: 11 additions & 16 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,25 +391,20 @@ jobs:
});
}

// --- Coverage gate: fail if any metric drops ---
if (covLine || covBranch || covMethod) {
const drops = [];
for (const { name, curr, baseKey } of [
{ name: 'Line', curr: covLine, baseKey: 'line' },
{ name: 'Branch', curr: covBranch, baseKey: 'branch' },
{ name: 'Method', curr: covMethod, baseKey: 'method' },
]) {
if (!curr) continue;
const b = baseCov[baseKey] || zeroCov;
const currPct = pct(curr.covered, curr.missed);
const basePct = pct(b.covered, b.missed);
// --- Coverage gate: fail if any class regresses on any metric ---
const regressions = [];
for (const [cls, curr] of Object.entries(classCounters)) {
const base = baseClasses[cls] || { line: zeroCov, branch: zeroCov, method: zeroCov };
for (const [metric, key] of [['Line', 'line'], ['Branch', 'branch'], ['Method', 'method']]) {
const currPct = pct(curr[key].covered, curr[key].missed);
const basePct = pct(base[key].covered, base[key].missed);
if (currPct < basePct - 0.05) {
drops.push(`${name}: ${currPct.toFixed(1)}% (was ${basePct.toFixed(1)}%, delta ${(currPct - basePct).toFixed(1)}%)`);
regressions.push(` ${cls} ${metric}: ${currPct.toFixed(1)}% (was ${basePct.toFixed(1)}%, delta ${(currPct - basePct).toFixed(1)}%)`);
}
}
if (drops.length > 0) {
core.setFailed(`Coverage decreased:\n${drops.join('\n')}`);
}
}
if (regressions.length > 0) {
core.setFailed(`Per-class coverage regressions detected:\n${regressions.join('\n')}\n\nUpdate test-baseline.json if these changes are intentional.`);
}
javadoc:
runs-on: ubuntu-latest
Expand Down
Loading