Skip to content

Add JSpecify annotations to language package nodes - redo (12 more) #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 10 commits into from
Mar 21, 2026
Merged

Add JSpecify annotations to language package nodes - redo (12 more) #4257

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b261a43
Add corrections to prompt
dondonz Feb 21, 2026
4df4205
Add first lot of changes
dondonz Feb 22, 2026
8fb836e
Add operation definition
dondonz Feb 22, 2026
298fea2
Add pretty ast printer
dondonz Feb 22, 2026
82712c7
Override name as non null
dondonz Feb 22, 2026
7a9e810
Add operation validator
dondonz Feb 22, 2026
dd49296
Adjust AST Printer
dondonz Feb 22, 2026
9e31132
Account for a nullable op name
dondonz Feb 22, 2026
1063251
Fix test for non-null selection set
dondonz Feb 22, 2026
f4e0f1b
Make OperationDefinition.operation non-null, default to QUERY
dondonz Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add corrections to prompt
  • Loading branch information
@dondonz
dondonz committed Feb 21, 2026
commit b261a43fc67ee697f4ce95e2bfb9c38aabfea193
11 changes: 10 additions & 1 deletion .claude/commands/jspecify-annotate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ Analyze this Java class and add JSpecify annotations based on:
5. Method implementations that return null or check for null
6. GraphQL specification details (see details below)

## API Compatibility and Breaking Changes

When adding JSpecify annotations, **DO NOT break existing public APIs**.
- **Do not remove interfaces** from public classes (e.g., if a class implements `NamedNode`, it must continue to do so).
- **Be extremely careful when changing methods to return `@Nullable`**. If an interface contract (or widespread ecosystem usage) expects a non-null return value, changing it to `@Nullable` is a breaking change that will cause compilation errors or `NullPointerException`s for callers. For example, if a method returned `null` implicitly but its interface requires non-null, you must honor the non-null contract (e.g., returning an empty string or default value instead of `null`).
- **Do not change the binary signature** of methods or constructors in a way that breaks backwards compatibility.

@dondonz dondonz Feb 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous attempt randomly deleted a constructor parameter which caused that PR to go off the rails. Let's fix that here

## GraphQL Specification Compliance
This is a GraphQL implementation. When determining nullability, consult the GraphQL specification (https://spec.graphql.org/draft/) for the relevant concept. Key principles:

Expand All @@ -26,7 +33,9 @@ If you find NullAway errors, try and make the smallest possible change to fix th

## Formatting Guidelines

Do not make spacing or formatting changes. Avoid adjusting whitespace, line breaks, or other formatting when editing code. These changes make diffs messy and harder to review. Only make the minimal changes necessary to accomplish the task.
- **Zero Formatting Changes**: Do NOT reformat the code.
- **Minimise Whitespace/Newline Changes**: Do not add or remove blank lines unless absolutely necessary. Keep the diff as clean as possible to ease the review process.
- Avoid adjusting whitespace, line breaks, or other formatting when editing code. These changes make diffs messy and harder to review. Only make the minimal changes necessary to accomplish the task.

## Cleaning up
Finally, can you remove this class from the JSpecifyAnnotationsCheck as an exemption
Expand Down