Skip to content

Add JSpecify annotations to 10 graphql.language classes #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 9 commits into from
Mar 22, 2026
Merged

Add JSpecify annotations to 10 graphql.language classes #4217

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
70d3d76
Initial plan
Copilot Jan 25, 2026
9d0253c
Add JSpecify annotations to 10 classes in graphql.language package
Copilot Jan 25, 2026
5842edf
Merge branch 'master' into copilot/add-jspecify-annotations
dondonz Feb 15, 2026
a87a8a3
Not nullable when Node is created
dondonz Feb 15, 2026
dcb7a66
Remove unnecessary null check
dondonz Feb 15, 2026
2d02ff0
Add nullable to input that ought to be nullable
dondonz Feb 15, 2026
2612804
Merge branch 'master' into copilot/add-jspecify-annotations
dondonz Mar 21, 2026
21261ed
Remove already-annotated classes from JSpecify exemption list
dondonz Mar 21, 2026
9d851ec
Merge remote-tracking branch 'origin/master' into copilot/add-jspecif…
dondonz Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove already-annotated classes from JSpecify exemption list 
NodeVisitor, NodeVisitorStub, SourceLocation, and Type are already
annotated with @NullMarked so they should not be in the exemption list.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@dondonz @claude
dondonz and claude committed Mar 21, 2026
commit 21261ed78fcdbf9388629c36f4aa3806705b66eb
4 changes: 0 additions & 4 deletions src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,17 +113,13 @@ class JSpecifyAnnotationsCheck extends Specification {
"graphql.language.ListType",
"graphql.language.NodeDirectivesBuilder",
"graphql.language.NodeParentTree",
"graphql.language.NodeVisitor",
"graphql.language.NodeVisitorStub",
"graphql.language.ScalarTypeDefinition",
"graphql.language.ScalarTypeExtensionDefinition",
"graphql.language.SchemaDefinition",
"graphql.language.SchemaExtensionDefinition",
"graphql.language.Selection",
"graphql.language.SelectionSet",
"graphql.language.SelectionSetContainer",
"graphql.language.SourceLocation",
"graphql.language.Type",
"graphql.language.TypeKind",
"graphql.language.TypeName",
"graphql.language.UnionTypeDefinition",
Expand Down