Skip to content

Add JSpecify annotations to 10 classes in graphql.language package and improve annotation prompt #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 7 commits into from
Mar 22, 2026
Merged

Add JSpecify annotations to 10 classes in graphql.language package and improve annotation prompt #4216

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c60fdf6
Initial plan
Copilot Jan 24, 2026
c02fa4e
Add JSpecify annotations to 10 classes in graphql.language package
Copilot Jan 24, 2026
3db2dde
Update JSpecify annotation prompt with effectiveness improvements
Copilot Jan 24, 2026
e7144c6
Allow slashes in dev branch names
dondonz Feb 8, 2026
5aaada6
Merge branch 'master' into copilot/add-jspecify-annotations-to-classes
dondonz Feb 14, 2026
0c7b9c3
Merge branch 'master' into copilot/add-jspecify-annotations-to-classes
dondonz Mar 21, 2026
4665320
Remove already-annotated classes from JSpecify exemption list
dondonz Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into copilot/add-jspecify-annotations-to-classes 
# Conflicts:
#	.claude/commands/jspecify-annotate.md
  • Loading branch information
@dondonz
dondonz committed Feb 14, 2026
commit 5aaada66572084a3f054c4817f60f7ac99d65870
4 changes: 1 addition & 3 deletions .claude/commands/jspecify-annotate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@ Before annotating, use `grep` to search for how each class is instantiated (e.g.

Analyze this Java class and add JSpecify annotations based on:
1. Set the class to be `@NullMarked`
2. Remove all the redundant `@NonNull` annotations that IntelliJ added
2. Remove all the redundant `@NonNull` annotations that IntelliJ added if there are any
3. Check Javadoc @param tags mentioning "null", "nullable", "may be null"
4. Check Javadoc @return tags mentioning "null", "optional", "if available"
5. Method implementations that return null or check for null
6. GraphQL specification details (see details below)

IntelliJ's infer nullity code analysis isn't comprehensive so feel free to make corrections.

## Pattern Examples

Here are concrete examples of common annotation patterns:
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.