Skip to content

New Exhaustion based data loader dispatching strategy #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 17 commits into from
Sep 28, 2025
Merged

New Exhaustion based data loader dispatching strategy #4130

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2cb5354
wip
andimarek Sep 27, 2025
0407946
working exhausted strategy
andimarek Sep 27, 2025
2e5c616
cleanup
andimarek Sep 27, 2025
f952bf1
cleanup
andimarek Sep 27, 2025
5f27d3d
test
andimarek Sep 27, 2025
dab44bf
tests
andimarek Sep 27, 2025
583c278
testing
andimarek Sep 27, 2025
8a24dca
testing and fixes delayed list of objects case
andimarek Sep 27, 2025
f40a4e5
testing
andimarek Sep 27, 2025
8ce7be7
testing
andimarek Sep 27, 2025
f0b2b09
testing
andimarek Sep 27, 2025
570e5c6
testing
andimarek Sep 27, 2025
860a0bd
remove not needed start stop complete call
andimarek Sep 27, 2025
b4f1d4b
make test stable
andimarek Sep 28, 2025
a96ba08
no field fetching callback for execute object needed
andimarek Sep 28, 2025
563abe9
improve performance by not handling executeObject (and field fetched …
andimarek Sep 28, 2025
6c9d267
performance improvements
andimarek Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove not needed start stop complete call
  • Loading branch information
@andimarek
andimarek committed Sep 27, 2025
commit 860a0bd528fd548b5b7fdc67f5727550d19a54d7
2 changes: 0 additions & 2 deletions src/main/java/graphql/execution/ExecutionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,9 +373,7 @@ protected Object resolveFieldWithInfo(ExecutionContext executionContext, Executi
return result;
} else {
try {
executionContext.getDataLoaderDispatcherStrategy().startComplete(parameters);
FieldValueInfo fieldValueInfo = completeField(fieldDef, executionContext, parameters, fetchedValueObj);
executionContext.getDataLoaderDispatcherStrategy().stopComplete(parameters);
fieldCtx.onDispatched();
fieldCtx.onCompleted(FetchedValue.getFetchedValue(fetchedValueObj), null);
return fieldValueInfo;
Expand Down