make result path to String faster

andimarek · May 16, 2025 · Mar 30, 2025 · Mar 30, 2025 · Mar 30, 2025 · Mar 31, 2025
commit ee1541d583cf2334a9da02fd65a897e1a6cec20d
diff --git a/src/main/java/graphql/execution/ResultPath.java b/src/main/java/graphql/execution/ResultPath.java
@@ -38,20 +38,36 @@ public static ResultPath rootPath() {
 
     // hash is effective immutable but lazily initialized similar to the hash code of java.lang.String
     private int hash;
+    private final String toStringValue;
 
     private ResultPath() {
         parent = null;
         segment = null;
+        this.toStringValue = initString();
     }
 
     private ResultPath(ResultPath parent, String segment) {
         this.parent = assertNotNull(parent, () -> "Must provide a parent path");
         this.segment = assertNotNull(segment, () -> "Must provide a sub path");
+        this.toStringValue = initString();
     }
 
     private ResultPath(ResultPath parent, int segment) {
         this.parent = assertNotNull(parent, () -> "Must provide a parent path");
         this.segment = segment;
+        this.toStringValue = initString();
+    }
+
+    private String initString() {
+        if (parent == null) {
+            return "";
+        }
+
+        if (ROOT_PATH.equals(parent)) {
+            return segmentToString();
+        }
+        return parent + segmentToString();
+
     }
 
     public int getLevel() {
@@ -294,15 +310,7 @@ public List<String> getKeysOnly() {
      */
     @Override
     public String toString() {
-        if (parent == null) {
-            return "";
-        }
-
-        if (ROOT_PATH.equals(parent)) {
-            return segmentToString();
-        }
-
-        return parent.toString() + segmentToString();
+        return toStringValue;
     }
 
     public String segmentToString() {