Skip to content

Singleton property data fetcher #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 12 commits into from
Nov 26, 2024
Merged

Singleton property data fetcher #3754

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
689e401
Use a singleton PropertyFetcher by default
bbakerman Nov 25, 2024
a5a22c0
Use a singleton PropertyFetcher by default - schema generator will us…
bbakerman Nov 25, 2024
0d80213
Use a singleton PropertyFetcher by default - renamed back to env for …
bbakerman Nov 25, 2024
612084e
Use a singleton PropertyFetcher by default - tweaked test wiring
bbakerman Nov 25, 2024
b8bfd4b
Use a singleton PropertyFetcher by default - tweaked test wiring and …
bbakerman Nov 25, 2024
70bac09
Use a singleton PropertyFetcher by default - now with SchemaGenerator…
bbakerman Nov 25, 2024
b8b2e26
Use a singleton PropertyFetcher by default - now with SchemaGenerator…
bbakerman Nov 25, 2024
424cac7
Use a singleton PropertyFetcher by default - broke out the code into …
bbakerman Nov 26, 2024
d1b132a
Merge branch 'singeton_property_data_fetcher' into no_df_if_codereg_d…
bbakerman Nov 26, 2024
886d745
Use a singleton PropertyFetcher by default - tweaked tests
bbakerman Nov 26, 2024
9ca4d30
Use a singleton PropertyFetcher by default - tweaked tests moar
bbakerman Nov 26, 2024
b13b7c8
Use a singleton PropertyFetcher by default - deprecated DFF method
bbakerman Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a singleton PropertyFetcher by default - schema generator will us… 
…e it
  • Loading branch information
@bbakerman
bbakerman committed Nov 25, 2024
commit a5a22c09921d84503fd0f3d4cddedcff7497ea82
7 changes: 3 additions & 4 deletions src/main/java/graphql/schema/idl/SchemaGeneratorHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ private DataFetcherFactory<?> buildDataFetcherFactory(BuildContext buildCtx,
if (codeRegistryDFF != null) {
return codeRegistryDFF;
}
dataFetcher = dataFetcherOfLastResort(wiringEnvironment);
dataFetcher = dataFetcherOfLastResort();
}
}
}
Expand Down Expand Up @@ -1087,9 +1087,8 @@ private Optional<OperationTypeDefinition> getOperationNamed(String name, Map<Str
return Optional.ofNullable(operationTypeDefs.get(name));
}

private DataFetcher<?> dataFetcherOfLastResort(FieldWiringEnvironment environment) {
String fieldName = environment.getFieldDefinition().getName();
return new PropertyDataFetcher(fieldName);
private DataFetcher<?> dataFetcherOfLastResort() {
return PropertyDataFetcher.singleton();
}

private List<Directive> directivesOf(List<? extends TypeDefinition<?>> typeDefinitions) {
Expand Down