Repository navigation
Schema generator reports false positive unsatisfiable input object cycle #4214
Description
Per the spec, cyclic input object fields of non-nullable list type with non-nullable items are valid since the field value can be an empty list. However, the NoUnbrokenInputCycles rule reports these input objects as invalid.
To reproduce, run the following code:
import graphql.schema.idl.NoopWiringFactory;
import graphql.schema.idl.RuntimeWiring;
import graphql.schema.idl.SchemaGenerator;
import graphql.schema.idl.SchemaParser;
public class Main {
public static void main(String[] args) {
String query = """
input Example {
self: [Example!]!
value: String
}
type Query {
example(example: Example): String
}
""".stripIndent();
TypeDefinitionRegistry typeDefinitionRegistry = new SchemaParser().parse(query);
RuntimeWiring runtimeWiring = RuntimeWiring.newRuntimeWiring().wiringFactory(new NoopWiringFactory()).build();
new SchemaGenerator().makeExecutableSchema(typeDefinitionRegistry, runtimeWiring);
}
}Observe an InvalidSchemaException is thrown with the message [self!] forms an unsatisfiable cycle
Activity
Fix #4214: Non-null list types should not be treated as unsatisfiable…
github-actions commentedon Mar 25, 2026
Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.
RafeArnold commentedon Mar 25, 2026
2cca660 appears to be a fix for this issue. Is it possible for this to be merged, @dondonz?
dondonz commentedon Mar 25, 2026
Hello thanks for reporting, will come back to this shortly
andimarek commentedon May 19, 2026
Verified against current master: this is still reproducible. Adding the SDL regression test for the issue fails with
[self!] forms an unsatisfiable cyclebefore the fix.Opened #4386 with the fix and regression coverage.