Repository navigation
Validation of deprecated non-nullable non-default argument is not correct #4182
Description
Describe the bug
GraphQL specification prohibits deprecation directive on non-nullable arguments without a default value, but graphql-java allows creation of such schema programmatically although there is validation (DeprecatedInputObjectAndArgumentsAreValid) that should prevent that.
Let say a new argument is created like this:
GraphQLArgument deprecatedArg = GraphQLArgument.newArgument()
.name("argument")
.type(GraphQLNonNull.nonNull(Scalars.GraphQLString))
.deprecate("Some very good reason")
.build();
The validation then tries to find deprecated applied directive:
But deprecatedDirective is null, and so it's reported as valid schema. The fix seems to be calling of argument.isDeprecated(), or combination of both approaches.
To Reproduce
GraphQLArgument deprecatedArg = GraphQLArgument.newArgument()
.name("input")
.type(GraphQLNonNull.nonNull(Scalars.GraphQLString))
.deprecate("Some very good reason")
.build();
GraphQLFieldDefinition field = GraphQLFieldDefinition.newFieldDefinition()
.name("field")
.type(Scalars.GraphQLString)
.argument(deprecatedArg)
.dataFetcher(env -> env.getArgument("input")) // for simplicity
.build();
GraphQLObjectType queryType = GraphQLObjectType.newObject()
.name("Query")
.field(field)
.build();
GraphQLSchema.newSchema()
.query(queryType)
.build(); // this method internally do the validation and should throw exception
Equivalent schema (implicit parts are omitted):
type Query {
field(input: String! @deprecated(reason : "Some very good reason")): String
}
Activity
bbakerman commentedon Dec 18, 2025
Ok I had a look at this and I know the reason its failing.
When types are created via SDL then code kicks in that notices the
@deprecatedArgdirective and then callsgraphql.schema.GraphQLArgument.Builder#deprecateto set the deprecation string into the argumentHowever the
DeprecatedInputObjectAndArgumentsAreValidvalidation code only looks for the actual directive. This is present in the case of SDL build schema but not direct like this.I will think more on how we can fix it.
#4182 - code built schemas should perform deprecated non null field v…
#4182 - code built schemas should perform deprecated non null field v…
bbakerman commentedon Dec 18, 2025
Fixed
Merge pull request #4194 from graphql-java/4182-deprecated-non-null-a…
github-actions commentedon Feb 17, 2026
Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.
bbakerman commentedon Feb 18, 2026
Done