Skip to content

feat: add connection method to find multiple relationships easily - #264

Closed
gounnaa wants to merge 0 commit into
graphframes:masterfrom
gounnaa:motifMaker
Closed

gounnaa wants to merge 0 commit into
graphframes:masterfrom
gounnaa:motifMaker

Conversation

@gounnaa

@gounnaa gounnaa commented Mar 13, 2018

Copy link
Copy Markdown
Contributor

This PR added connection method to generate motif query easier. See the examples in test case.

@codecov-io

codecov-io commented Mar 13, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #264 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   88.49%   88.55%   +0.06%     
==========================================
  Files          20       20              
  Lines         739      743       +4     
  Branches       57       58       +1     
==========================================
+ Hits          654      658       +4     
  Misses         85       85
Impacted Files Coverage Δ
src/main/scala/org/graphframes/GraphFrame.scala 86.82% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a142721...2982bf5. Read the comment docs.

@gounnaa gounnaa changed the title add connection method to find multiple relationships easily Add connection method to find multiple relationships easily Mar 13, 2018
@felixcheung

Copy link
Copy Markdown
Member

this just create the motif pattern as a string?

@gounnaa

gounnaa commented Mar 14, 2018

Copy link
Copy Markdown
Contributor Author

Yes. I was searching for Cypher like syntax for (v1)-[*1..5]->(v2) pattern, but I was not able to find it. For a query to find some relations in depth, typing the long pattern manually was not good experience actually. It is just a starting point, and applying any better idea will be appreciated.

@felixcheung

Copy link
Copy Markdown
Member

I see. Kinda like this http://graphframes.github.io/user-guide.html#tab_python_3

Would it more useful to implement support for variable pattern (v1)-[*1..5]->(v2)? It shouldn't be very difficult to do..

@gounnaa

gounnaa commented Mar 23, 2018

Copy link
Copy Markdown
Contributor Author

Right. But, I am not sure about the syntax is good enough. When I google it literally as it is, it detects the query from a bot and blocks my browser. The other concern is, if it is only for Neo4j not open Cyper standards, will it be ok to use?

@felixcheung

Copy link
Copy Markdown
Member

I think that's Cypher syntax right? I think that's good to have.
https://www.opencypher.org/
https://s3.amazonaws.com/artifacts.opencypher.org/openCypher9.pdf
"Variable-length pattern matching"

@gounnaa

gounnaa commented Mar 27, 2018 •

Copy link
Copy Markdown
Contributor Author

Great! Variable-length pattern matching!

@SemyonSinchenko

Copy link
Copy Markdown
Collaborator

Hello @goungoun ! Thanks for that! Any chance you resolve the merge-conflicts and update the PR?

@SemyonSinchenko SemyonSinchenko changed the title Add connection method to find multiple relationships easily feat: add connection method to find multiple relationships easily Sep 10, 2025
@gounnaa gounnaa closed this Sep 10, 2025
@gounnaa

gounnaa commented Sep 10, 2025 •

Copy link
Copy Markdown
Contributor Author

Hello @SemyonSinchenko! Thanks for reminding me.
This PR has been open for a long time without progress. I am sorry for that. It happened to be closed automatically while synchronizing my repository, but let me continue to look at how I can reflect @felixcheung's advice.

@gounnaa

gounnaa commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

@SemyonSinchenko, I opened a new PR to continue on the feature.
#685

This branch was previously deployed

2 inactive deployments
github-pages — 19ddd867 Deployed Sep 9, 2025 by SemyonSinchenko via deploy #26
pypi — 19ddd867 Deployed Sep 9, 2025 by james-willis via release #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants