Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: autocommit sample #172

Merged
larkee merged 16 commits into from
Dec 30, 2020
Merged

feat: autocommit sample #172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
beb5bdf
feat: autocommit sample
AlisskaPie Nov 19, 2020
adc05b0
remove unused imports
AlisskaPie Nov 19, 2020
1659802
Merge branch 'master' into autocommit_samples
c24t Nov 23, 2020
1de5c29
Remove samples/samples init
c24t Nov 24, 2020
85885f5
No package-relative imports in samples
c24t Nov 24, 2020
f8a6c80
fix check errors, rename test file
AlisskaPie Nov 25, 2020
1fb7019
move ResultsChecksum() to test
AlisskaPie Nov 30, 2020
09c5246
use connection.Cursor in patch
AlisskaPie Nov 30, 2020
f8d4d4c
Merge branch 'master' into autocommit_samples
AVaksman Dec 3, 2020
0e1e66c
Merge branch 'master' into autocommit_samples
c24t Dec 7, 2020
cab9f08
Apply suggestions from code review
Dec 9, 2020
f1353a2
Update samples/samples/autocommit_test.py
Dec 9, 2020
4e5465b
lint fix
Dec 9, 2020
12bdf95
Merge branch 'master' into autocommit_samples
c24t Dec 9, 2020
447d96f
Merge branch 'master' into autocommit_samples
c24t Dec 29, 2020
5fb4326
Merge branch 'master' into autocommit_samples
larkee Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix check errors, rename test file
  • Loading branch information
@AlisskaPie
AlisskaPie committed Nov 25, 2020
commit f8a6c8002077a294be56f15fc1f47e2164d35ae4
3 changes: 3 additions & 0 deletions samples/samples/autocommit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,14 @@
def enable_autocommit_mode(instance_id, database_id):
"""Enables autocommit mode."""
# [START spanner_enable_autocommit_mode]
from google.cloud.spanner_dbapi.checksum import ResultsChecksum

connection = connect(instance_id, database_id)
connection.autocommit = True
print("Autocommit mode is enabled.")

cursor = connection.cursor()
cursor._checksum = ResultsChecksum()

@larkee larkee Nov 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the user need to initialise a private variable? Can this not be initialised as part of the cursor factory?

@AlisskaPie AlisskaPie Nov 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! And sorry for the delayed answer.
I've made an update and placed this part in the test.

@larkee larkee Dec 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite what I meant. The sample now looks as I would expect but I'm unclear as to why you still need to set cursor._checksum in the test. Is there a reason that _checksum defaults to None? Could it be updated to ResultsChecksum() instead?


cursor.execute(
"""CREATE TABLE Singers (
Expand Down
0 samples/samples/test_autocommit.py → samples/samples/autocommit_test.py
View file
Open in desktop
File renamed without changes.