Skip to content
This repository was archived by the owner on Oct 13, 2026. It is now read-only.

chore: transition the library to the new microgenerator #158

Merged
plamut merged 35 commits into from
Sep 7, 2020
Merged

chore: transition the library to the new microgenerator #158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
d218232
chore: regenerate the library with microgenerator
plamut Jul 14, 2020
529c853
Update setup.py for Python 3.6+
plamut Jul 14, 2020
a744caf
Fix GAPIC types imports
plamut Jul 14, 2020
f416327
Inject SERVICE_ADDRESS and _DEFAULT_SCOPES to generated classes
plamut Jul 15, 2020
256081a
Cleanup types.py
plamut Jul 15, 2020
dbf76f0
Adjust determining message size to new protobufs
plamut Jul 14, 2020
1c08fc4
Adjust Message.publish_time property to new protobuf
plamut Jul 14, 2020
8568830
Remove client_config argument to publisher client
plamut Jul 14, 2020
5a881e5
Remove subscriber client config
plamut Jul 14, 2020
022e710
Fix method patch in gapic instance method test
plamut Jul 14, 2020
d44494f
Fix transport-related test failures
plamut Jul 14, 2020
19952aa
Adjust calls to changed client.publish() signature
plamut Jul 14, 2020
d8b0a34
Remove obsolete replacement rules from synth.py
plamut Jul 15, 2020
cd8ad7e
Fix streaming pull monkeypatch (no prefetch)
plamut Jul 15, 2020
1253156
Update supported Python versions in README
plamut Jul 15, 2020
5a78181
Adjust system tests to new method signatures
plamut Jul 16, 2020
2b01cc4
Adjust method calls in samples to new client
plamut Jul 14, 2020
b336b2f
Fix tests creating subscription with custom settings
plamut Jul 17, 2020
1170672
Regenerate library with latest synthtool
plamut Jul 23, 2020
466a8db
Adjust IAM tests to new IAM method signatures
plamut Jul 23, 2020
7d82ece
Fix docstring format in generated *_iam_policy() methods
plamut Jul 23, 2020
4add1b9
Iterate directly over topic subscriptions response
plamut Jul 24, 2020
758a470
Copy default publish Retry to a class variable
plamut Jul 28, 2020
62d0d07
Adjust retry deadline if publish with ordering key
plamut Jul 30, 2020
2ed758e
Add suport for custom publish retry settings
plamut Jul 30, 2020
4c6a6a0
Add UPGRADING guide to docs
plamut Jul 31, 2020
5624026
Mention default retry settings in sample comments
plamut Aug 5, 2020
fe3d041
Merge branch 'master' into use-microgenerator
plamut Aug 15, 2020
3eb9a05
Remove synth URL changes from templates
plamut Aug 15, 2020
3bc393b
Adjust the ordering key sample to new code
plamut Aug 18, 2020
9f5aeee
Adjust client to changes in generated code
plamut Aug 19, 2020
c57c8b2
Regenerate the code to pick the latest changes
plamut Aug 19, 2020
cca5683
Bump dependencies to latest versions
plamut Aug 19, 2020
c29d7f8
Optimize creating and accesing pubsub messages
plamut Aug 20, 2020
23e1612
Regenerate the code with the latest changes
plamut Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove client_config argument to publisher client 
The argument is not supported anymore in the new generated client.
  • Loading branch information
@plamut
plamut committed Jul 16, 2020
commit 856883023cf84a6f0ebb67185a2504e0fe987cd6
16 changes: 0 additions & 16 deletions google/cloud/pubsub_v1/publisher/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,22 +176,6 @@ def __init__(self, batch_settings=(), publisher_options=(), **kwargs):
# For a transient failure, retry publishing the message infinitely.
self.publisher_options = types.PublisherOptions(*publisher_options)
self._enable_message_ordering = self.publisher_options[0]
if self._enable_message_ordering:
# Set retry timeout to "infinite" when message ordering is enabled.
# Note that this then also impacts messages added with an empty ordering
# key.
client_config = _set_nested_value(
kwargs.pop("client_config", {}),
2 ** 32,
[
"interfaces",
"google.pubsub.v1.Publisher",
"retry_params",
"messaging",
"total_timeout_millis",
],
)
kwargs["client_config"] = client_config

# Add the metrics headers, and instantiate the underlying GAPIC
# client.
Expand Down
13 changes: 0 additions & 13 deletions tests/unit/pubsub_v1/publisher/test_publisher_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,19 +111,6 @@ def test_message_ordering_enabled():
assert client._enable_message_ordering


def test_message_ordering_changes_retry_deadline():
creds = mock.Mock(spec=credentials.Credentials)

client = publisher.Client(credentials=creds)
assert client.api._method_configs["Publish"].retry._deadline == 60

client = publisher.Client(
publisher_options=types.PublisherOptions(enable_message_ordering=True),
credentials=creds,
)
assert client.api._method_configs["Publish"].retry._deadline == 2 ** 32 / 1000


def test_publish():
creds = mock.Mock(spec=credentials.Credentials)
client = publisher.Client(credentials=creds)
Expand Down