Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

feat: Added flushes/close functionality to logging handlers #917

Merged
gkevinzheng merged 11 commits into from
Mar 31, 2025
Merged

feat: Added flushes/close functionality to logging handlers #917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9f85e57
feat: Added flushes/close functionality to logging handlers
gkevinzheng Jun 24, 2024
d725eff
Fixed unit test issues.
gkevinzheng Jul 29, 2024
9ee7bae
linting
gkevinzheng Jul 30, 2024
ae3ece3
more linting
gkevinzheng Jul 31, 2024
b46779e
Addressed code review feedback
gkevinzheng Aug 16, 2024
1b037b6
Refactored _close
gkevinzheng Mar 13, 2025
c1d1f3f
馃 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 13, 2025
da74511
Added system tests
gkevinzheng Mar 13, 2025
cc32e9b
make transport_open private
gkevinzheng Mar 31, 2025
72a8ff6
馃 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 31, 2025
e04a188
Merge branch 'main' into cloud-logging-handler-flush
gkevinzheng Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed unit test issues.
  • Loading branch information
@gkevinzheng
gkevinzheng committed Mar 10, 2025
commit d725effc0ab9baf411fb7f0d6fd73bf7b9bc1a26
1 change: 0 additions & 1 deletion google/cloud/logging_v2/handlers/transports/background_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ def _close(self):
if self.stop(grace_period=self._grace_period) and threading.main_thread().is_alive():
print("Sent all pending logs.", file=sys.stderr)
else:
print(f"Thread main is alive: {threading.main_thread().is_alive()}", file=sys.stderr)
print(
"Failed to send %d pending logs." % (self._queue.qsize(),),
file=sys.stderr,
Expand Down
9 changes: 2 additions & 7 deletions tests/unit/handlers/transports/test_background_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,6 @@ def test__close_main_thread_not_alive(self):

self.assertRegex(stderr_mock.getvalue(), re.compile("^%s$" % _CLOSE_THREAD_SHUTDOWN_ERROR_MSG, re.MULTILINE))

print(worker._grace_period)
print(worker._queue.qsize())
print(stderr_mock.getvalue())
self.assertFalse(worker.is_alive)
self.fail()

def test_close_unregister_atexit(self):
worker = self._make_one(_Logger(self.NAME))

Expand Down Expand Up @@ -467,7 +461,8 @@ def test__thread_main_main_thread_terminated(self):
main_thread_obj_mock = mock.Mock()
main_thread_func_mock.return_value = main_thread_obj_mock
main_thread_obj_mock.is_alive = mock.Mock(return_value=False)

self._enqueue_record(worker, "1")
self._enqueue_record(worker, "2")
worker._thread_main()

self.assertFalse(worker._cloud_logger._batch.commit_called)
Expand Down