Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

feat: structured log adapter #751

Closed
NewGlad wants to merge 11 commits into from
Closed

feat: structured log adapter #751

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
619ba4a
feat: Add AppendLabelLoggingAdapter to have an ability to adapt logge…
May 25, 2023
4d67513
Merge branch 'main' into main
daniel-sanche Sep 25, 2023
97dfbfe
Merge branch 'main' into main
daniel-sanche Sep 25, 2023
c61ba2a
Merge branch 'main' into main
NewGlad May 16, 2024
68c09ab
Merge branch 'main' into main
chalmerlowe Feb 19, 2026
0b7ef4e
updates with more idiomatic python for simplicity
chalmerlowe Feb 19, 2026
bf2dab0
updates __all__
chalmerlowe Feb 19, 2026
51aaba9
updates formatting via black
chalmerlowe Feb 20, 2026
fb5a63c
updates multi-process handling to rely on the more robust spawn
chalmerlowe Feb 20, 2026
31414f6
updates system test to account for spawned fork and pickling error
chalmerlowe Feb 20, 2026
e62cad6
corrects linting, imports
chalmerlowe Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
corrects linting, imports
  • Loading branch information
@chalmerlowe
chalmerlowe committed Feb 20, 2026
commit e62cad6883184bc61a9ed1b7cb3bb00b4f71f3f2
27 changes: 13 additions & 14 deletions tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import google.cloud.logging
from google.cloud._helpers import UTC
from google.cloud.logging_v2.handlers import CloudLoggingHandler
from google.cloud.logging_v2.handlers.transports import BackgroundThreadTransport
from google.cloud.logging_v2.handlers.transports import SyncTransport
from google.cloud.logging_v2 import client
from google.cloud.logging_v2.resource import Resource
Expand Down Expand Up @@ -150,17 +149,17 @@ def _shared_subprocess_worker(handler_name, log_message, cleanup_mode="close"):

# 1. Create a fresh client inside the child process
local_client = Client()

# 2. Setup the handler and logger
handler = CloudLoggingHandler(
local_client, name=handler_name, transport=BackgroundThreadTransport
)
cloud_logger = logging.getLogger("subprocess_logger")
cloud_logger.addHandler(handler)

# 3. Perform the log
cloud_logger.warning(log_message)

# 4. Handle the specific cleanup requested by the test
if cleanup_mode == "close":
handler.close()
Expand Down Expand Up @@ -752,43 +751,43 @@ def test_log_handler_otel_integration(self):

def test_log_handler_close(self):
import multiprocessing

ctx = multiprocessing.get_context("spawn")

LOG_MESSAGE = "This is a test of handler.close before exiting."
handler_name = self._logger_name("close-test")

# Setup for verification (parent uses its own client)
logger = Config.CLIENT.logger(handler_name)
self.to_delete.append(logger)

proc = ctx.Process(
args=(handler_name, LOG_MESSAGE, "close")
args=(handler_name, LOG_MESSAGE, "close")
)
proc.start()
proc.join()

entries = _list_entries(logger)
self.assertEqual(len(entries), 1)
self.assertEqual(entries[0].payload, LOG_MESSAGE)

def test_log_handler_flush(self):
import multiprocessing

ctx = multiprocessing.get_context("spawn")

LOG_MESSAGE = "This is a test of client.flush_handlers."
handler_name = self._logger_name("flush-test")

logger = Config.CLIENT.logger(handler_name)
self.to_delete.append(logger)

proc = ctx.Process(
args=(handler_name, LOG_MESSAGE, "flush")
args=(handler_name, LOG_MESSAGE, "flush")
)
proc.start()
proc.join()

entries = _list_entries(logger)
self.assertEqual(len(entries), 1)
self.assertEqual(entries[0].payload, LOG_MESSAGE)
Expand Down
Loading