Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: populate default timeout and retry after client-side timeout #896

Merged
gcf-merge-on-green merged 12 commits into from
Aug 25, 2021
Merged

fix: populate default timeout and retry after client-side timeout #896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4e37426
fix: populate default `timeout` and actually retry after timeout
tswast Aug 23, 2021
4fa81d8
fix test_client tests
tswast Aug 23, 2021
4acdaa6
fix remaining unit tests
tswast Aug 24, 2021
f1f7395
Merge branch 'master' into issue889-default-timeout
tswast Aug 24, 2021
02f1829
Merge branch 'master' into issue889-default-timeout
tswast Aug 24, 2021
24d1049
add tests for timeout errors
tswast Aug 24, 2021
725de7d
retry all timeout errors
tswast Aug 24, 2021
14bb277
Merge remote-tracking branch 'origin/issue889-default-timeout' into i…
tswast Aug 24, 2021
bbfcc53
Merge branch 'master' into issue889-default-timeout
tswast Aug 24, 2021
d1fee5a
Merge branch 'master' into issue889-default-timeout
tswast Aug 25, 2021
10940af
Merge branch 'master' into issue889-default-timeout
gcf-merge-on-green[bot] Aug 25, 2021
7e7fc5c
Merge branch 'master' into issue889-default-timeout
tswast Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
retry all timeout errors
  • Loading branch information
@tswast
tswast committed Aug 24, 2021
commit 725de7dd114e2eb47d817c5676ecfff5006285e4
2 changes: 1 addition & 1 deletion google/cloud/bigquery/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
exceptions.BadGateway,
requests.exceptions.ChunkedEncodingError,
requests.exceptions.ConnectionError,
requests.exceptions.ReadTimeout,
requests.exceptions.Timeout,
auth_exceptions.TransportError,
)

Expand Down
10 changes: 9 additions & 1 deletion tests/unit/test_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,18 @@ def test_w_unstructured_requests_chunked_encoding_error(self):
exc = requests.exceptions.ChunkedEncodingError()
self.assertTrue(self._call_fut(exc))

def test_w_unstructured_requests_timeout(self):
def test_w_unstructured_requests_connecttimeout(self):
exc = requests.exceptions.ConnectTimeout()
self.assertTrue(self._call_fut(exc))

def test_w_unstructured_requests_readtimeout(self):
exc = requests.exceptions.ReadTimeout()
self.assertTrue(self._call_fut(exc))

def test_w_unstructured_requests_timeout(self):
exc = requests.exceptions.Timeout()
self.assertTrue(self._call_fut(exc))

def test_w_auth_transporterror(self):
from google.auth.exceptions import TransportError

Expand Down