Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: accept DatasetListItem where DatasetReference is accepted #597

Merged
plamut merged 20 commits into from
Apr 12, 2021
Merged

feat: accept DatasetListItem where DatasetReference is accepted #597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
260672c
split out and pytestify list_tables tests.
Apr 7, 2021
3a122d7
list_tables now accepts DatasetListItem objects
Apr 7, 2021
d453031
Get coverage to 100%
Apr 7, 2021
61b53bc
lint
Apr 7, 2021
0b1b7c8
Update exception text for DatasetListItem
Apr 7, 2021
1349d4b
Bypass opentelemetry tracing in unit tests.
Apr 8, 2021
a93d6dc
Got rid of opentelemetry tracing checks. They aren't needed.
Apr 8, 2021
b4ea2a8
abstracted dataset-argument handling
Apr 8, 2021
7128789
Converted list_model tests to pytest and included check for dataset p…
Apr 8, 2021
0ee721b
removed unneeded blanl lines.
Apr 8, 2021
c778e9b
Made list_routines accept DatasetListItem
Apr 8, 2021
4fb971b
create_dataset accepts DatasetListItem
Apr 8, 2021
4154204
Converted list_routine tests to pytest
Apr 8, 2021
be90063
include string dataset representation in dataset polymorphism.
Apr 8, 2021
bbe1fd2
removed some unused imports
Apr 8, 2021
2aa4954
Updated delete_dataset tests
Apr 8, 2021
fd39b8b
black
Apr 8, 2021
05d89f8
lint
Apr 8, 2021
440ac82
We don't actually need to avoid opentelemetry
Apr 8, 2021
d4d329e
fixed docstrings to include DatasetListItem in dataset polymorphic APIs.
Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
Jim Fulton
Jim Fulton committed Apr 7, 2021
commit 61b53bcaeee3f0d1a5c701d868a5688c7533b33e
2 changes: 1 addition & 1 deletion tests/unit/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def get_reference(x):
(google.cloud.bigquery.dataset.DatasetReference, identity),
(make_dataset, identity),
(make_dataset_list_item, get_reference),
]
]

dataset_polymorphic = pytest.mark.parametrize(
"make_dataset,get_reference", dataset_like
Expand Down
2 changes: 0 additions & 2 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2926,7 +2926,6 @@ def test_update_table_delete_property(self):
self.assertEqual(req[1]["data"], sent)
self.assertIsNone(table3.description)


def test_list_models_empty_w_timeout(self):
path = "/projects/{}/datasets/{}/models".format(self.PROJECT, self.DS_ID)
creds = _make_credentials()
Expand Down Expand Up @@ -3102,7 +3101,6 @@ def test_list_routines_wrong_type(self):
DatasetReference(self.PROJECT, self.DS_ID).table("foo")
)


def test_delete_dataset(self):
from google.cloud.bigquery.dataset import Dataset
from google.cloud.bigquery.dataset import DatasetReference
Expand Down