Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: pass retry from Job.result() to Job.done() #41

Merged
tswast merged 16 commits into from
Nov 3, 2020
Merged

feat: pass retry from Job.result() to Job.done() #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
29fb5e5
feat(bigquery): pass retry from Job.result() to Job.done().
Feb 21, 2020
bdfe0e4
Merge branch 'master' into retry_from_result_to_done
Oct 22, 2020
cde2c2c
fix merge conflicts
Oct 22, 2020
878be0b
drop the comment
Oct 22, 2020
11cc5de
use kwargs sentinel
Oct 22, 2020
789cf49
check the mock retry
Oct 22, 2020
06f13bd
update dependencies
Oct 27, 2020
e415fdd
Merge branch 'master' into retry_from_result_to_done
Oct 27, 2020
30aea1d
Merge branch 'master' into retry_from_result_to_done
tswast Oct 27, 2020
dc33f0a
Merge branch 'master' into retry_from_result_to_done
Oct 28, 2020
925621e
use kwargs pattern
Oct 28, 2020
531d3d8
Merge branch 'retry_from_result_to_done' of https://github.com/q-logi…
Oct 28, 2020
a200fb2
Merge branch 'master' into retry_from_result_to_done
tswast Oct 29, 2020
d30bb6b
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani Nov 2, 2020
0827daa
feat: added unit test for retry
HemangChothani Nov 2, 2020
7b214f6
feat: added more exceptions
HemangChothani Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update dependencies
  • Loading branch information
IlyaFaer
IlyaFaer committed Oct 27, 2020
commit 06f13bdfbb1daa39a2091aee2cd9465576fab461
3 changes: 1 addition & 2 deletions google/cloud/bigquery/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,8 +818,7 @@ def result(self, retry=DEFAULT_RETRY, timeout=None):
if self.state is None:
self._begin(retry=retry, timeout=timeout)

kwargs = {} if retry is DEFAULT_RETRY else {"retry": retry}
return super(_AsyncJob, self).result(timeout=timeout, **kwargs)
return super(_AsyncJob, self).result(timeout=timeout, retry=retry)

def cancelled(self):
"""Check if the job has been cancelled.
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# 'Development Status :: 5 - Production/Stable'
release_status = "Development Status :: 5 - Production/Stable"
dependencies = [
"google-api-core[grpc] >= 1.22.2, < 2.0.0dev",
"google-api-core[grpc] >= 1.23.0, < 2.0.0dev",
"proto-plus >= 1.10.0",
"google-cloud-core >= 1.4.1, < 2.0dev",
"google-resumable-media >= 0.6.0, < 2.0dev",
Expand Down
2 changes: 1 addition & 1 deletion testing/constraints-3.6.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
google-api-core==1.22.2
google-api-core==1.23.0
google-cloud-bigquery-storage==2.0.0
google-cloud-core==1.4.1
google-resumable-media==0.6.0
Expand Down