Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: require python 3.7+ #410

Merged
parthea merged 7 commits into from
Aug 10, 2022
Merged

fix: require python 3.7+ #410

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e016197
chore(python): drop python 3.6
gcf-owl-bot[bot] Jul 5, 2022
5cdc37a
require python 3.7+ in setup.py
parthea Jul 7, 2022
19c5f6b
remove python 3.6 sample configs
parthea Jul 7, 2022
73cd18c
exclude templated README
parthea Jul 12, 2022
b600e40
remove python 3.6 from noxfile
parthea Jul 23, 2022
da410eb
remove python 3.6 from remaining files
parthea Jul 23, 2022
48ddff8
remove testing/constraints-3.6.txt
parthea Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove python 3.6 from noxfile
  • Loading branch information
@parthea
parthea committed Jul 23, 2022
commit b600e4030fe4c9cb29e6bfd70a15ff51c63efe88
19 changes: 9 additions & 10 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@
]


def _greater_or_equal_than_36(version_string):
def _greater_or_equal_than_37(version_string):
tokens = version_string.split(".")
for i, token in enumerate(tokens):
try:
tokens[i] = int(token)
except ValueError:
pass
return tokens >= [3, 6]
return tokens >= [3, 7]


@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down Expand Up @@ -122,9 +122,9 @@ def default(session, install_grpc=True):
),
]

# Inject AsyncIO content and proto-plus, if version >= 3.6.
# Inject AsyncIO content and proto-plus, if version >= 3.7.
# proto-plus is needed for a field mask test in test_protobuf_helpers.py
if _greater_or_equal_than_36(session.python):
if _greater_or_equal_than_37(session.python):
session.install("asyncmock", "pytest-asyncio", "proto-plus")

# Having positional arguments means the user wants to run specific tests.
Expand All @@ -136,28 +136,27 @@ def default(session, install_grpc=True):
session.run(*pytest_args)


@nox.session(python=["3.6", "3.7", "3.8", "3.9", "3.10"])
@nox.session(python=["3.7", "3.8", "3.9", "3.10"])
def unit(session):
"""Run the unit test suite."""
default(session)


@nox.session(python=["3.6", "3.10"])
@nox.session(python=["3.8", "3.10"])
def unit_wo_grpc(session):
"""Run the unit test suite w/o grpcio installed"""
default(session, install_grpc=False)


@nox.session(python="3.6")
@nox.session(python="3.8")
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""

session.install("docutils", "Pygments")
session.run("python", "setup.py", "check", "--restructuredtext", "--strict")


# No 3.7 because pytype supports up to 3.6 only.
@nox.session(python="3.6")
@nox.session(python="3.8")
def pytype(session):
"""Run type-checking."""
session.install(".[grpc]", "pytype >= 2019.3.21")
Expand All @@ -178,7 +177,7 @@ def mypy(session):
session.run("mypy", "google", "tests")


@nox.session(python="3.6")
@nox.session(python="3.8")
def cover(session):
"""Run the final coverage report.

Expand Down