Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: ensure exception is available when BackgroundConsumer open stream fails #357

Merged
parthea merged 12 commits into from
Oct 17, 2023
Merged

fix: ensure exception is available when BackgroundConsumer open stream fails #357

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1a64fff
fix: ensure exception is available when BackgroundConsumer open strea…
parthea Mar 14, 2022
97c2363
chore: fix coverage
parthea Mar 15, 2022
2b24714
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea Jun 14, 2022
947b657
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea Dec 28, 2022
ad1f29f
Merge branch 'main' into fix-background-consumer-start-eats-exception
rosiezou Feb 3, 2023
7ec7832
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea Sep 1, 2023
c7f63bd
Address review comments
parthea Oct 13, 2023
3304ef1
revert
parthea Oct 13, 2023
e120a0c
address review feedback
parthea Oct 13, 2023
753a591
raise grpc.RpcError instead of GoogleAPICallError
parthea Oct 13, 2023
3c1daa9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 13, 2023
9423063
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
@parthea
parthea committed Oct 13, 2023
commit c7f63bd270d81f75abdf0282bd3c4be4de02bdbd
3 changes: 3 additions & 0 deletions google/api_core/bidi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ def add_done_callback(self, callback):
self._callbacks.append(callback)

def _on_call_done(self, future):
# Note that grpc's "future" here is also a grpc.RpcError.
# `grpc.RpcError` is also `grpc.call` based on
# https://github.com/grpc/grpc/issues/10885#issuecomment-302651331
for callback in self._callbacks:
callback(future)

Expand Down