Repository navigation
BigQuery: deprecate client.dataset() part 1
#9032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6b3a2a3
Merge pull request #26 from googleapis/master
mf2199 4c6d7b4
Move every snippet to it's own file. Create test templates.
377310c
list_datasets_by_label
emar-kar 5ce976f
Merge remote-tracking branch 'upstream/master'
emar-kar a7b2376
manage_dataset_labels
emar-kar 0de5d8b
add_empty_column
emar-kar 5e05cd8
browse_table_data
emar-kar f6b60a0
dataset_exists
emar-kar a773251
complete change of dataset_exists
emar-kar 8375877
Merge remote-tracking branch 'upstream/master'
emar-kar a0792bd
five updated snippets
emar-kar 95dc8f8
Update datasets.rst
emar-kar cf7576e
cosmetic chgs
emar-kar 5654dcd
cosmetic chgs
emar-kar 0e7ccf5
*.rst files correction
emar-kar 6dd1174
update first-five
emar-kar 7a654c3
Update test_dataset_exists.py
emar-kar 0cf0071
update list_datasets_by_label
emar-kar f602e3f
Update test_browse_table_data.py
emar-kar 0bf9aab
The update of the first-five according to the requested chgs
emar-kar 2e50a81
snippets file reformatted
emar-kar 9e77624
Update tables.rst
emar-kar e37f5a2
update manage_dataset_labels
emar-kar af27c29
update browse_table_data
emar-kar 47ee156
deleted extra spaces
emar-kar b78f6c9
update import settings
emar-kar 6ee351e
reformate samples/
emar-kar 14757f6
minor update
emar-kar 9941957
cosmetic chgs
emar-kar 9cc5661
Merge branch 'master' into first-five
emar-kar 70c032f
Update test_list_datasets_by_label.py
emar-kar cde3e62
update delete_dataset_labels
emar-kar 9d3c1aa
Update test_dataset_label_samples.py
emar-kar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cosmetic chgs
grammar fix
- Loading branch information
commit 5654dcd4f780b123fe5b206a56aa3d8538e9d7c9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,5 +24,5 @@ def test_dataset_exists(capsys, client, random_dataset_id): | |
| dataset = client.create_dataset(dataset) | ||
| dataset_exists.dataset_exists(client, random_dataset_id) | ||
| out, err = capsys.readouterr() | ||
| assert "Dataset {} not found".format(random_dataset_id) in out | ||
| assert "Dataset {} is not found".format(random_dataset_id) in out | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's move this assert to after the first time we call |
||
| assert "Dataset {} already exists".format(random_dataset_id) in out | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.