Skip to content

Address third part of 477: Move Dataset.get_entity to Key. #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 2 commits into from
Jan 6, 2015
Merged

Address third part of 477: Move Dataset.get_entity to Key. #480

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62204e7
Move Dataset.get_entity to Key.
dhermes Jan 2, 2015
c8e145f
Adding back dataset's connection in Entity.reload.
dhermes Jan 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding back dataset's connection in Entity.reload.
  • Loading branch information
@dhermes
dhermes committed Jan 6, 2015
commit c8e145f05d535c8e73e9b8bfcf69097f97e3e57a
3 changes: 2 additions & 1 deletion gcloud/datastore/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ def reload(self):
exist only locally.
"""
key = self._must_key
entity = key.get()
connection = self._must_dataset.connection()
entity = key.get(connection=connection)

if entity:
self.update(entity)
Expand Down
3 changes: 2 additions & 1 deletion gcloud/datastore/test_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ def is_partial(self):
def path(self):
return self._path

def get(self):
def get(self, connection=None):
self._connection_used = connection
return self._stored


Expand Down