Skip to content

Add handling of missing properties in SchemaField.from_api_repr() #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theacodes merged 2 commits into from
Jan 18, 2018
Merged

Add handling of missing properties in SchemaField.from_api_repr() #4754

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e029f
Add handling of missing properties SchemaField.from_api_repr
alanbato Jan 15, 2018
6d16c41
Add testing for defaults in from_api_repr function
alanbato Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add testing for defaults in from_api_repr function
  • Loading branch information
@alanbato
alanbato committed Jan 17, 2018
commit 6d16c415b5a46f7161a3729c7de144ac622108b7
10 changes: 10 additions & 0 deletions bigquery/tests/unit/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,16 @@ def test_from_api_repr(self):
self.assertEqual(field.fields[0].field_type, 'INTEGER')
self.assertEqual(field.fields[0].mode, 'NULLABLE')

def test_from_api_repr_defaults(self):
field = self._get_target_class().from_api_repr({
'name': 'foo',
'type': 'record',
})
self.assertEqual(field.name, 'foo')
self.assertEqual(field.field_type, 'RECORD')
self.assertEqual(field.mode, 'NULLABLE')
self.assertEqual(len(field.fields), 0)

def test_name_property(self):
name = 'lemon-ness'
schema_field = self._make_one(name, 'INTEGER')
Expand Down