Skip to content

fix empty set #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucemia wants to merge 4 commits into from
Closed

fix empty set #404

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79ff1a3
fix empty set
lucemia Dec 3, 2014
0d86944
add test case
lucemia Dec 28, 2014
9e2d1f0
fix pep8
lucemia Dec 28, 2014
15a507e
document the save_entity will ignore properties whose value is empty …
lucemia Dec 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix empty set
  • Loading branch information
@lucemia
lucemia committed Dec 3, 2014
commit 79ff1a35d1b08f468fac659d7df8bdeae8e9a019
3 changes: 3 additions & 0 deletions gcloud/datastore/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,9 @@ def save_entity(self, dataset_id, key_pb, properties,
insert.key.CopyFrom(key_pb)

for name, value in properties.items():
if isinstance(value, list) and len(value) == 0:
continue

prop = insert.property.add()
# Set the name of the property.
prop.name = name
Expand Down