Skip to content

Fix #81 getting a datastore.entity by key or path #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 5 commits into from
Dec 3, 2014
Merged

Fix #81 getting a datastore.entity by key or path #393

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e1b026
getting a datastore.entity by key or path
bryanyang0528 Nov 27, 2014
1806341
del space
bryanyang0528 Nov 27, 2014
e47ccc1
coding style revised
bryanyang0528 Nov 27, 2014
e75899b
add a test for odd list and nonetype
bryanyang0528 Nov 28, 2014
fd0f674
del unused code
bryanyang0528 Nov 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
del unused code
  • Loading branch information
@bryanyang0528
bryanyang0528 committed Nov 29, 2014
commit fd0f674dfa257e3c4140dfcfcc6493576df8fbe5
8 changes: 0 additions & 8 deletions gcloud/datastore/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,7 @@ def test_get_entity_odd_nonetype(self):
from gcloud.datastore.connection import datastore_pb
DATASET_ID = 'DATASET'
KIND = 'Kind'
ID = 1234
entity_pb = datastore_pb.Entity()
entity_pb.key.partition_id.dataset_id = DATASET_ID
path_element = entity_pb.key.path_element.add()
path_element.kind = KIND
path_element.id = ID
prop = entity_pb.property.add()
prop.name = 'foo'
prop.value.string_value = 'Foo'
connection = _Connection(entity_pb)
dataset = self._makeOne(DATASET_ID, connection)
with self.assertRaises(ValueError):
Expand Down