Skip to content

Open privkey file in binary mode. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Nov 10, 2014
Merged

Open privkey file in binary mode. #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Open privkey file in binary mode. 
Fixes #361.
  • Loading branch information
@tseaver
tseaver committed Nov 10, 2014
commit c4bea8805ede4247df3bce10f23e123e98944c0d
2 changes: 1 addition & 1 deletion gcloud/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ def get_for_service_account(client_email, private_key_path, scope=None):
"""
return client.SignedJwtAssertionCredentials(
service_account_name=client_email,
private_key=open(private_key_path).read(),
private_key=open(private_key_path, 'rb').read(),
scope=scope)