Skip to content

Fix #313: Add Key properties #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 6 commits into from
Nov 7, 2014
Merged

Fix #313: Add Key properties #349

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8c4391
Avoid re-iterating summary line.
tseaver Nov 6, 2014
bafe213
Add accessors for read-only properties of a server-side object.
tseaver Nov 6, 2014
2b26990
Add writable 'Key' properties matching writable server-side properties.
tseaver Nov 6, 2014
520de84
Factor out simple scalar property creation using helper methods.
tseaver Nov 6, 2014
f8d8844
Docstrings.
tseaver Nov 7, 2014
a915447
One-line docstrings.
tseaver Nov 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Avoid re-iterating summary line.
  • Loading branch information
@tseaver
tseaver committed Nov 7, 2014
commit e8c4391e0cc3c8bf94054a50a74aaa6fa99e029f
11 changes: 2 additions & 9 deletions gcloud/storage/bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ def etag(self):
https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: string
:returns: a unique identifier for the bucket and current metadata.
"""
return self.properties['etag']

Expand All @@ -411,7 +410,6 @@ def id(self):
See: https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: string
:returns: a unique identifier for the bucket.
"""
return self.properties['id']

Expand Down Expand Up @@ -501,8 +499,6 @@ def metageneration(self):
See: https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: integer
:returns: count of times since creation the bucket's metadata has
been updated.
"""
return self.properties['metageneration']

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Expand All @@ -524,7 +520,6 @@ def project_number(self):
See: https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: integer
:returns: a unique identifier for the bucket.
"""
return self.properties['projectNumber']

Expand All @@ -535,7 +530,6 @@ def self_link(self):
See: https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: string
:returns: URI of the bucket.
"""
return self.properties['selfLink']

Expand All @@ -547,8 +541,7 @@ def storage_class(self):
https://cloud.google.com/storage/docs/durable-reduced-availability

:rtype: string
:returns: the storage class for the bucket (currently one of
``STANDARD``, ``DURABLE_REDUCED_AVAILABILITY``)
:returns: Currently one of "STANDARD", "DURABLE_REDUCED_AVAILABILITY"
"""
return self.properties['storageClass']

Expand All @@ -559,7 +552,7 @@ def time_created(self):
See: https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: string
:returns: timestamp for the bucket's creation, in RFC 3339 format.
:returns: timestamp in RFC 3339 format.
"""
return self.properties['timeCreated']

Expand Down