Skip to content

Allow overriding dataset's project during construction. #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 3 commits into from
Dec 5, 2016
Merged

Allow overriding dataset's project during construction. #2809

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab0bf9c
Allow overriding dataset's project during construction.
tseaver Dec 5, 2016
d5091bc
Add a system test exercising non-default project for dataset.
tseaver Dec 5, 2016
e866177
Freeze project selection in dataset ctor.
tseaver Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Freeze project selection in dataset ctor. 
Addresses:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/181434795#L1784-L1785
  • Loading branch information
@tseaver
tseaver committed Dec 5, 2016
commit e86617735f968584fb231108013227be2d98a083
4 changes: 2 additions & 2 deletions bigquery/google/cloud/bigquery/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def __init__(self, name, client, access_grants=(), project=None):
self._properties = {}
# Let the @property do validation.
self.access_grants = access_grants
self._project = project
self._project = project or client.project

@property
def project(self):
Expand All @@ -124,7 +124,7 @@ def project(self):
:rtype: str
:returns: the project (derived from the client).
"""
return self._project or self._client.project
return self._project

@property
def path(self):
Expand Down