Skip to content

Adding gRPC stubs to Bigtable clients #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 3 commits into from
Nov 17, 2015
Merged

Adding gRPC stubs to Bigtable clients #1154

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6320af
Add stubs to Bigtable Client class.
dhermes Sep 24, 2015
32c4c95
Adding ability to start/stop clients.
dhermes Sep 24, 2015
9cd7022
Adding comment about gRPC stubs context managers.
dhermes Nov 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding comment about gRPC stubs context managers. 
In particular, explaining why we __enter__ them but
have no corresponding __enter__ for our users.
  • Loading branch information
@dhermes
dhermes committed Nov 16, 2015
commit 9cd70229cc78d96ea4f71ac8bed80ab51adbde4d
5 changes: 5 additions & 0 deletions gcloud/bigtable/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ def start(self):
if self.is_started():
return

# NOTE: We __enter__ the stubs more-or-less permanently. This is
# because only after entering the context managers is the
# connection created. We don't want to immediately close
# those connections since the client will make many
# requests with it over HTTP/2.
self._data_stub = self._make_data_stub()
self._data_stub.__enter__()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

if self._admin:
Expand Down