You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support 'blob_value' / 'blob_key_value' in datastore protobufs #233
Note that handling 'blob_value' values will require us to think harder about handling "bytes" (marshalled via 'blob_value') vs. "text" (marshalled via 'string_value'). At the moment, we rather sloppily conflate handling both Python2 'str' and 'unicode' via 'string_value'.
@tseaver Saw your fix for blob_value in #233.
If we add list_value to _set_protobuf_value, then we should support all value types when writing entities.
Activity
dhermes commentedon Oct 9, 2014
This is something we could check in an automated fashion:
or
tseaver commentedon Oct 16, 2014
Note that handling 'blob_value' values will require us to think harder about handling "bytes" (marshalled via 'blob_value') vs. "text" (marshalled via 'string_value'). At the moment, we rather sloppily conflate handling both Python2 'str' and 'unicode' via 'string_value'.
silvolu commentedon Oct 18, 2014
@tseaver as you mentioned in #157, we should raise exceptions after the value types coverage is complete.
silvolu commentedon Oct 18, 2014
I think we're missing value types in
_get_protobuf_attribute_and_value(https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/gcloud/datastore/_helpers.py#L17) as well.tseaver commentedon Oct 18, 2014
That will get tricksy:
Right now:
which can't be right, long-term. It should be (under Python2):
and under Py3k:
OTOH, '_get_value_from_value_pb' looks right:
We'd like for the following to work:
but it currently returns None.
tseaver commentedon Oct 18, 2014
Changing to use 'blob_value' for bytes / native str in Python2 will be the one which confounds users expectations.
dhermes commentedon Oct 18, 2014
Indeed. I wonder if people have done things to deal with this in other libraries. Potentially encoding/decoding to ASCII or something similar?
silvolu commentedon Oct 18, 2014
@tseaver Saw your fix for
blob_valuein #233.If we add
list_valueto_set_protobuf_value, then we should support all value types when writing entities.tseaver commentedon Oct 18, 2014
@silvolu see #265.
Merge pull request #263 from tseaver/233-support_blob_value
tseaver commentedon Oct 20, 2014
#263 adds 'blob_value' support. @silvolu says we can skip 'blob_key_value'.
66 remaining items
build(deps): bump requests from 2.28.1 to 2.31.0 in /synthtool/gcp/te…
feat: add support for Python 3.10 (#233)
chore: release 2.2.0 (#238)
build: update actions/upload-artifact and actions/download-artifact (#…
feat: Add support for Python 3.12 (#233)
chore: update copyright year to 2022 (#233)
Release v1.3.0 (#233)
samples: fix flaky tests (#233)
feat: Add Python 3.13 trove classifier (#233)
Update README.rst (#233)
chore(py_library): add some excludes in docs/conf.py (#233)
fix: fix execute insert for homogeneous statement (#233)
fix(db_api): revert Mutations API usage (#285)
chore: use templated renovate.json (#233)
feat: Add Python 3.13 trove classifier (#233)