You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As an experiment I tried to get datastore/entity.py to conform. Notice that #188 has come up as an issue in f7de067 since the linter is fooled about the type of self.key().
@tseaver Can you take a look and let me know what you think?
Some notes:
Neither pep8ify nor pyfmt properly indent docstrings
pyfmt is much slower than pep8ify (at least on the first run)
pylint -E <file> only checks errors
pylint --reports=n <file> only shows the offending lines
I spent way too much time hacking on the ast but have a decent hack which I think will do the part missing in pep8ify, which is correct indenting of docstrings: https://gist.github.com/dhermes/85c3a3a464d2cff312ea
UPDATE:
I destroyed these branches by changing the gcloud-dir one into an upstream branch of the four indents PR (#207) and merging the setup one into the same PR.
Activity
dhermes commentedon Sep 25, 2014
Both
pep8ifyandpyfmtwill rewrite code to adhere.They both seem to be unsure of themselves when it comes to
maximum_line_length.After running, it'd be smart to check with
git diff --color-wordslocally. Luckily GitHub also now has nice word highlighting in diffs.dhermes commentedon Sep 25, 2014
As an experiment I tried to get
datastore/entity.pyto conform. Notice that #188 has come up as an issue in f7de067 since the linter is fooled about the type ofself.key().@tseaver Can you take a look and let me know what you think?
Some notes:
Neither
pep8ifynorpyfmtproperly indent docstringspyfmtis much slower thanpep8ify(at least on the first run)pylint -E <file>only checks errorspylint --reports=n <file>only shows the offending linesAll PyLint codes: http://pylint-messages.wikidot.com/all-codes
To get just the errors and the global evaluation score
Adding color
pylint --output-format=colorizeddhermes commentedon Sep 25, 2014
I spent way too much time hacking on the
astbut have a decent hack which I think will do the part missing inpep8ify, which is correct indenting of docstrings:https://gist.github.com/dhermes/85c3a3a464d2cff312ea
dhermes commentedon Sep 27, 2014
I have two more branches:
https://github.com/dhermes/gcloud-python/tree/pep8ify-gcloud-dir
https://github.com/dhermes/gcloud-python/tree/pep8ify-setup
UPDATE:
I destroyed these branches by changing the
gcloud-dirone into an upstream branch of the four indents PR (#207) and merging thesetupone into the same PR.kleyow commentedon Sep 28, 2014
@dhermes I'm in the process of cleaning as well pyflakes/pep8 just double checking, we using 2 space instead of 4 right?
tseaver commentedon Sep 28, 2014
We decided to move to 4 spaces (to ease community contributions).
dhermes commentedon Sep 28, 2014
@kleyow Which files are you working on? Hoping to avoid double work.
Also, for tests without docstrings, are we OK with a global
# pylint: disable=missing-docstringat the top?dhermes commentedon Sep 28, 2014
Sorry, just saw #200
tseaver commentedon Oct 13, 2014
#217 adds pep8-conformance to the tox tests.
Merge pull request googleapis#179 from O365/improvements
67 remaining items
chore: release 1.27.0 (#179)
chore: release 0.8.0 (#179)
chore(deps): update actions/download-artifact action to v3 (#179)
chore: new owl bot post processor docker image (#179)
feat: support pandas 2.0 release candidate (#179)
chore: update dependency protobuf >= 3.20.2 (#179)
chore: [autoapprove] Update `black` and `isort` to latest versions (#179
tests: clean up properly after completion (#179)
Use correct class when deserializing a PolyModel entity. (#186)
tests: clean up properly after completion (#179)
Fix retrieval of default project ID on Windows (#179)
feat: add _async_resumable_media experimental support (#179)
django: fix text lookups if an underscore is in the value
chore: require samples checks (#179)
fix: use `id` field for Attributes instead of `name` (#179)