Repository navigation
In storage.Key.connection, determine appropriate behavior (null return vs. throwing error) #147
Description
From TODO: "If a bucket isn't defined, this is basically useless. Where do we throw an error?"
See gcloud.storage.Key.connection for relevant code and #146 for some context.
Activity
dhermes commentedon Sep 22, 2014
git blameoutput:tseaver commentedon Sep 23, 2014
Docstring mandates a return of None.
dhermes commentedon Sep 23, 2014
I think @jgeewax was suggesting an error might be more useful than the null value that the docstring describes.
tseaver commentedon Oct 28, 2014
@jgeewax @dhermes Given that we allow construction of Keys with
bucket=None, read-only access to the connection returning None in that case seems better than an exception: anybody trying use it without checking for None will get an immediate AttributeError for whatever method.dhermes commentedon Oct 28, 2014
SGTM
I have no strong feelings on this. I just filed it to get the
TODOout of the code as part of #146 and move the discussion here.tseaver commentedon Oct 31, 2014
@silvolu I recommend closing this issue.
101 remaining items
chore(deps): update dependency google-cloud-error-reporting to v1.2.0 (…
fix: await on to_wrap in AsyncTransactional (#147)
chore: upgrade gapic-generator-python to 0.39.1 (#147)
chore: Add renovate.json (#147)
Use "gcloud config config-helper" to read the project ID from the Goo…
chore(main): release 1.5.0 (#147)
test: require Kokoro as a presubmit (#147)
fix(storage): add documentaion of list_blobs with user project (#147)
feat!: migrate to v2.0.0 (#147)
chore: release 2.0.0 (#163)
chore: release 1.3.0 (#147)
chore(main): release 1.5.0 (#147)
chore(deps): update vulnerable transitive dependencies in sqlalchemy-…
chore(sqlalchemy-spanner): update vulnerable transitive dependencies
chore(sqlalchemy-spanner): update vulnerable transitive dependencies …