Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the Conscrypt security provider for the default HTTP transport in BigQueryJdbcProxyUtility and excludes shaded Netty from gRPC relocation in pom.xml. It also introduces a new integration test, ITPqcValidationTest, to verify that both REST and gRPC transports negotiate post-quantum hybrid key exchange (X25519MLKEM768). Feedback on the test code suggests optimizing reflection calls by retrieving fields outside of the loop to improve efficiency.
Comment on lines
+320
to
+347
| List<Object> contexts = findInstancesInGraph(readClient, openSslCtxClass, 25); | ||
| for (Object ctx : contexts) { | ||
| Field enginesField = openSslCtxClass.getDeclaredField("engines"); | ||
| enginesField.setAccessible(true); | ||
| Map<?, ?> engines = (Map<?, ?>) enginesField.get(ctx); | ||
| for (Object engineObj : engines.values()) { | ||
| if (openSslEngineClass.isInstance(engineObj)) { | ||
| SSLEngine engine = (SSLEngine) engineObj; | ||
| SSLSession session = engine.getSession(); | ||
| Field groupsField = openSslEngineClass.getDeclaredField("groups"); | ||
| groupsField.setAccessible(true); | ||
| String[] engineGroups = (String[]) groupsField.get(engineObj); | ||
| if (engineGroups == null || engineGroups.length == 0) { | ||
| engineGroups = defaultGroups; | ||
| } | ||
| String primaryKeyShare = | ||
| (engineGroups != null && engineGroups.length > 0) ? engineGroups[0] : "unknown"; | ||
| results.add( | ||
| new HandshakeRecord( | ||
| session.getPeerHost(), | ||
| engine.getClass().getName(), | ||
| false, | ||
| session.getProtocol(), | ||
| session.getCipherSuite(), | ||
| primaryKeyShare)); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
To improve efficiency and maintainability, retrieve the enginesField and groupsField reflectively once outside the loops rather than repeatedly calling getDeclaredField and setAccessible(true) on every iteration.
List<Object> contexts = findInstancesInGraph(readClient, openSslCtxClass, 25);
if (!contexts.isEmpty()) {
Field enginesField = openSslCtxClass.getDeclaredField("engines");
enginesField.setAccessible(true);
Field groupsField = openSslEngineClass.getDeclaredField("groups");
groupsField.setAccessible(true);
for (Object ctx : contexts) {
Map<?, ?> engines = (Map<?, ?>) enginesField.get(ctx);
for (Object engineObj : engines.values()) {
if (openSslEngineClass.isInstance(engineObj)) {
SSLEngine engine = (SSLEngine) engineObj;
SSLSession session = engine.getSession();
String[] engineGroups = (String[]) groupsField.get(engineObj);
if (engineGroups == null || engineGroups.length == 0) {
engineGroups = defaultGroups;
}
String primaryKeyShare =
(engineGroups != null && engineGroups.length > 0) ? engineGroups[0] : "unknown";
results.add(
new HandshakeRecord(
session.getPeerHost(),
engine.getClass().getName(),
false,
session.getProtocol(),
session.getCipherSuite(),
primaryKeyShare));
}
}
}
}References
- Avoid adding defensive null checks for values that are guaranteed to be non-null by design, as this can hide invariant breaks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.