fix: serialize ClientSecrets with JSON.generate - #28074
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
torreypayne
requested changes
Oct 2, 2026
| def to_json | ||
| return Json.dump(to_hash) | ||
| def to_json(*args) | ||
| return JSON.generate(to_hash, *args) |
Member
There was a problem hiding this comment.
On second thought, can we actually just fix the typo and do JSON.dump instead? cc @quartzmo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27757; submitted following maintainer confirmation.
Replace the undefined Json constant with JSON.generate(to_hash, *args). Forwarding arguments supports both direct to_json and JSON.generate(secrets); both have regression specs.
Verification on Ruby 4.0.6: 88 ClientSecrets examples and the full 502-example core suite pass; Ruby syntax and git diff --check pass. The repository-pinned RuboCop 0.93.1 could not start under this bundle because benchmark is not declared for Ruby 4; no lint success is claimed.
AI-assisted implementation, reviewed and verified.