Skip to content

Add CodeArea validity, better error-checking in Decode(). #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viettaml wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add CodeArea validity, better error-checking in Decode(). #185

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aaff4a5
Merge pull request #2 from google/master
viettaml Aug 6, 2018
56a9739
Add new codearea_test
viettaml Aug 6, 2018
b588377
Add new CodeArea methods.
viettaml Aug 6, 2018
da64929
Implement new CodeArea methods.
viettaml Aug 6, 2018
531dc1b
Implement new CodeArea unit tests.
viettaml Aug 6, 2018
1514918
Add minimal validity checking to Decode().
viettaml Aug 6, 2018
811358d
Add DecodingChecks:DecodeOutOfRange subtest.
viettaml Aug 6, 2018
a701945
Merge branch 'main' into master
viettaml Sep 8, 2022
c043ee5
Fix invalid code check after PR conflict resolution.
viettaml Sep 8, 2022
63dcc27
Apply clang-format to codearea.cc to pass clang-format check.
viettaml Sep 8, 2022
0063da6
Merge branch 'main' into master
viettaml Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add DecodingChecks:DecodeOutOfRange subtest.
  • Loading branch information
@viettaml
viettaml authored Aug 6, 2018
commit 811358d719241ff30cc807b8672cc0b5e0322ece
10 changes: 10 additions & 0 deletions cpp/openlocationcode_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ TEST_P(EncodingChecks, Encode) {
EXPECT_EQ(test_data.code, actual_code);
// Now decode the code and check we get the correct coordinates.
CodeArea actual_rect = Decode(test_data.code);
EXPECT_TRUE(actual_rect.IsValid());
EXPECT_NEAR(expected_rect.GetCenter().latitude,
actual_rect.GetCenter().latitude, 1e-10);
EXPECT_NEAR(expected_rect.GetCenter().longitude,
Expand All @@ -131,6 +132,15 @@ TEST_P(EncodingChecks, Encode) {
INSTANTIATE_TEST_CASE_P(OLC_Tests, EncodingChecks,
::testing::ValuesIn(GetEncodingDataFromCsv()));

TEST(DecodingChecks, DecodeOutOfRange) {
// Leading longitude digit "W" is out of range.
EXPECT_FALSE(Decode(std::string("9W4Q0000+")).IsValid());
// Leading latitude digit "F" is out of range.
EXPECT_FALSE(Decode(std::string("F2+")).IsValid());
// Invalid digits in post-separator portion.
EXPECT_FALSE(Decode(std::string("7Q7Q7Q7Q+5Z")).IsValid());
}

struct ValidityTestData {
std::string code;
bool is_valid;
Expand Down