Repository navigation
Fix issue for downstream users of Maven 3.10.0, and clean up obsolete profile. - #563
Merged
Merged
Conversation
… profile. IIUC: For security reasons, Maven has changed to disallow _dependencies_ to select a profile based on what files exist on disk. So, in order to detect whether to include `tools.jar` on the classpath, we must check the Java version, rather than checking whether `tools.jar` exists. This change, once released and pulled into Auto, should resolve the problem seen at head, including in such PRs as google/auto#2160. I also figured that it was about time to remove the Mac profile that sounds like it may have supported Java *6* there. RELNOTES=Fixed Java 8 build configuration to work for downstream users of Maven 3.10.0. PiperOrigin-RevId: 996668159
copybara-service
Bot
force-pushed
the
test_996593822
branch
from
October 9, 2026 18:55
9b7bbe5 to
63b2b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue for downstream users of Maven 3.10.0, and clean up obsolete profile.
IIUC: For security reasons, Maven has changed to disallow dependencies to select a profile based on what files exist on disk. So, in order to detect whether to include
tools.jaron the classpath, we must check the Java version, rather than checking whethertools.jarexists.This change, once released and pulled into Auto, should resolve the problem seen at head, including in such PRs as google/auto#2160.
I also figured that it was about time to remove the Mac profile that sounds like it may have supported Java 6 there.
RELNOTES=Fixed Java 8 build configuration to work for downstream users of Maven 3.10.0.