Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User impact
When the model omits a required OpenAPI path parameter, the
RestApiToolcall raises an uncaughtKeyErrorthat aborts the entire agent invocation. The model never receives retry guidance, so the run dies instead of recovering.Fixes #7282.
Technical cause
RestApiTool._prepare_request_paramsbuilds the URL withself.endpoint.path.format(**path_params)(rest_api_tool.py:463). If a{placeholder}was not supplied,str.format()raisesKeyError. The caller incall()only convertsInputValidationErrorinto a structured tool error (rest_api_tool.py:610-613), so theKeyErrorescapes and ends the run.Fix
Before formatting, collect the template's placeholders with
string.Formatter().parse()(which correctly ignores escaped{{/}}) and raiseInputValidationErrorlisting any that are missing. The existingcall()handler already convertsInputValidationErrorinto the retryable{"error": ...}tool response, so the model gets a structured error naming exactly which path parameters it must supply.Testing plan
pytest tests/unittests/tools/openapi_tool/openapi_spec_parser/test_rest_api_tool.pyon this branch — 94 passed; the same 5 tests fail identically on pristine upstreammain(pre-existing environment failures inhttpxURL parsing of test fixtures, unrelated to this change).RestApiToolover path template/users/{user_id}with a pathApiParameter. On upstreammain, omittinguser_idraised an uncaughtKeyError: 'user_id'; on this branch it raisesInputValidationError("Missing required path parameter(s) ['user_id'] ..."), whichcall()already converts into the structured retryable tool error. Control withuser_idsupplied buildshttps://example.com/users/abcon both.