Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Problem:
SkillToolset's default system instruction tells the model to callrun_skill_script, but the toolset registers onlylist_skills,load_skill, andload_skill_resource.Solution: Remove the instruction to call the unregistered tool. Add a regression test that extracts the tool names mentioned by the default instruction, verifies the extracted list is nonempty, and checks each name against the actual tool list. Custom system instructions retain their existing behavior.
Testing Plan
Unit Tests:
Java 17, with Google Java formatting enabled:
mvn -B -ntp -pl core -Dfmt.skip=false testFull core completed with 2,016 tests, 0 failures, 0 errors, and 24 skipped in each of the
default-testandbasicexecutions.SkillToolsetTestran all 6 tests successfully, including the new default-instruction regression and the existing custom-instruction coverage. The additional configured Surefire executions also completed successfully. The two main executions run the same suite; their counts are not added together as distinct tests.Manual End-to-End (E2E) Tests: Not run against a live model provider. The regression exercises the toolset's injected system instruction and compares it with the tools returned by
getTools(); the existing custom-instruction test remains part of the suite.Checklist
No script-execution tool, dependency, or public API is added.