Skip to content

Added clear function to FrameBuffer. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebftw wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added clear function to FrameBuffer. #190

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
529d04e
Added clear function to FrameBuffer.
sebftw Jan 22, 2019
e132039
Removed clear() and added clearflags().
sebftw Feb 7, 2019
9ab668a
Removed redundant glClearColor from window.py.
sebftw Feb 7, 2019
0750927
Removed clearflags from the framebuffer example.
sebftw Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added clear function to FrameBuffer. 
Instead of calling window.clear() when we have a framebuffer activated we should call framebuffer.clear().
Then it makes sure to clear the renderbuffers that are set. Of course merging this change will make my other pull request redundant:
#189
  • Loading branch information
@sebftw
sebftw authored Jan 22, 2019
commit 529d04e7e40f579ebca64d487bc5b61feded837d
11 changes: 10 additions & 1 deletion glumpy/gloo/framebuffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

@window.event
def on_draw(dt):
window.clear()
framebuffer.activate()
framebuffer.clear()
quad.draw(gl.GL_TRIANGLE_STRIP)
framebuffer.deactivate()
"""
Expand Down Expand Up @@ -353,6 +353,15 @@ def resize(self, width, height):
self._pending_attachments.append((target, self.stencil))
self._need_attach = True

def clear(self):
""" Clear the framebuffer """

clearflags = gl.GL_COLOR_BUFFER_BIT
if self._depth is not None:
clearflags |= gl.GL_DEPTH_BUFFER_BIT
if self._stencil is not None:
clearflags |= gl.GL_STENCIL_BUFFER_BIT
gl.glClear(clearflags)

def _create(self):
""" Create framebuffer on GPU """
Expand Down