Skip to content

Resolve several major issues: Vertical Metrics, Monospace Recognition #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottta wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Resolve several major issues: Vertical Metrics, Monospace Recognition #227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8394262
Avoid write lastChange and displayString to version control
ottta May 26, 2024
972eb52
Check `Use Typo Metrics` to get more consistent vertical metrics
ottta May 26, 2024
7da07ce
Change win metrics to avoid clipping
ottta May 26, 2024
d68bcf3
Resolve #21 #37 #169
ottta May 26, 2024
753e4aa
Resolve #111 not recognized as monospace font
ottta May 26, 2024
424fe7c
Export to `.ttf` (Glyphsapp export)
ottta May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve #21 #37 #169 
- #21 #37 "Hanging Font": Miss configure `typo` and `hhea` value. Adjust this value will "centering" glyphs across the vertical bounding box.

- #169  Probably same as above, tweaking `typo` and `hhea` does resolve the `line-height` or `leading` default to `1.2` or `120%` from the upm value.

UPM = 2000
(typo/hhea)Ascenders = 1930
(typo/hhea)Descenders = -470
(typo/hhea)LineGap = 0

Total:
ascender + abs(descenders) + linegap = 2400

Note that "Gcommaaccent" may be truncated in environments that have `overflow: hidden`

Please see these documentation:
- https://googlefonts.github.io/gf-guide/metrics.html#6-winascent-and-windescent-values-must-be-the-same-as-the-familys-tallestdeepest-ymin-and-ymax-bounding-box-values
- https://googlefonts.github.io/gf-guide/metrics.html#11-the-sum-of-the-fonts-vertical-metric-values-absolute-should-be-20-30-greater-than-the-fonts-upm
  • Loading branch information
@ottta
ottta committed May 26, 2024
commit d68bcf32f2c91a7221767fda63e8167655eef016
104 changes: 56 additions & 48 deletions sources/Monaspace Argon Var.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,27 +1260,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1331,27 +1331,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1401,27 +1401,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1471,27 +1471,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand All @@ -1502,6 +1502,14 @@ name = winDescent;
value = 786;
}
);
guides = (
{
pos = (83,1930);
},
{
pos = (19,-470);
}
);
id = "05608152-0947-468D-8C2A-07D081228424";
metricValues = (
{
Expand Down Expand Up @@ -1541,27 +1549,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1613,27 +1621,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1684,27 +1692,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1755,27 +1763,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down
Loading