Skip to content

Use dom-input-range instead of internal implementation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansan5653 merged 3 commits into from
May 15, 2024
Merged

Use dom-input-range instead of internal implementation #55

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180d221
Use `dom-input-range` instead of internal implementation
iansan5653 May 9, 2024
04fe10d
Update other dependencies & test files
iansan5653 May 9, 2024
8824151
Update `dom-input-range`
iansan5653 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use dom-input-range instead of internal implementation
  • Loading branch information
@iansan5653
iansan5653 authored May 9, 2024
commit 180d221e04fb4396a71003d4d09d17fdf40a49b6
8 changes: 7 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
],
"prettier": "@github/prettier-config",
"dependencies": {
"@github/combobox-nav": "^2.0.2"
"@github/combobox-nav": "^2.0.2",
"dom-input-range": "^1.1.3"
},
"devDependencies": {
"@github/prettier-config": "0.0.4",
Expand Down
4 changes: 2 additions & 2 deletions src/text-expander-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Combobox from '@github/combobox-nav'
import query from './query'
import textFieldSelectionPosition from './text-field-selection-position'
import {InputRange} from 'dom-input-range'

type Match = {
text: string
Expand Down Expand Up @@ -103,7 +103,7 @@ class TextExpander {

this.expander.dispatchEvent(new Event('text-expander-activate'))

let {top, left} = textFieldSelectionPosition(this.input, match.position)
let {top, left} = new InputRange(this.input, match.position).getBoundingClientRect()
if (isTopLayer(menu)) {
const rect = this.input.getBoundingClientRect()
top += rect.top
Expand Down
115 changes: 0 additions & 115 deletions src/text-field-mirror.ts
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions src/text-field-selection-position.ts
View file
Open in desktop

This file was deleted.