Make task-lists-elements CSP Trusted Types compatible - #35
Merged
Merged
Conversation
KyFaSt
force-pushed
the
pse-paved-paths/trusted-types-compatibility
branch
from
December 21, 2022 14:28
da82936 to
8fc70a8
Compare
* this change doesn't actually add any security to task-lists-elements, it effectively just adheres to the trusted types API by not passing bare strings directly to
KyFaSt
force-pushed
the
pse-paved-paths/trusted-types-compatibility
branch
from
December 21, 2022 14:30
8fc70a8 to
98a446c
Compare
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
fletchto99
approved these changes
Dec 21, 2022
fletchto99
left a comment
fletchto99
left a comment
Member
There was a problem hiding this comment.
Looks good from a pse-architecture perspective! Its unfortunate we need to be so verbose for something like this but unfortunately we have no way to indicate that an innerHTML is coming from a hardcoded string 😓
colebemis
approved these changes
Dec 21, 2022
keithamus
approved these changes
Jan 3, 2023
lgarron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes task-lists-elements compatible with the CSP directive Trusted Types. This CSP directive allows developers to mark a value as a Trusted Type, usually this would be done in conjunction with running some type of sanitizer like DOMPurify to ensure the value doesn't contain any unsafe elements. Fortunately, task-lists-elements doesn't have major violations, just this one. Unfortunately the change in this PR does not buy any security benefits, it just adheres to the Trusted Types API -- not passing bare strings directly to potentially dangerous injection sinks. Currently this implementation is the best way to make this library compatible with trusted types.