This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Repository navigation
Skip failed files during indexing instead of aborting the whole index operation - #419
Merged
Merged
Conversation
dcreager
approved these changes
Apr 10, 2024
dcreager
left a comment
dcreager
left a comment
Contributor
There was a problem hiding this comment.
My idea is to make sure the version in the source always reflects the changes w.r.t. the last release.
Agreed, good call!
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running an
indexcommand in the CLI would abort if stack graph construction for one of the indexed failes failed.This may be fine when debugging a spec, but too punitive for users, who would like as much partial information as possible in the database, even if some files are not covered by the spec, or bugs exist.
This PR changes the behavior to mark those files as failed (as we already do for files with parse errors) but continue with the remaining files.
Fixes #418.
Note that I've also bumped the version already, even though I'm not sure if I'll release right away or not.
In the past we'd only bump the version right before a release, which sometimes resulted in confusing situations when depending on the repo instead of released version.
The versions would still be comaptible, even thought he source already contained incompatible changes.
My idea is to make sure the version in the source always reflects the changes w.r.t. the last release.