Skip to content

feat: add kiro-cli and AGENT_CONFIG consistency coverage #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 9 commits into from
Mar 3, 2026
Merged

feat: add kiro-cli and AGENT_CONFIG consistency coverage #1690

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a48cbd9
feat: add kiro-cli and AGENT_CONFIG consistency coverage
medhatgalal Feb 25, 2026
bbfd0d0
fix: address PR feedback for kiro-cli migration
medhatgalal Feb 25, 2026
e65af72
test: assert init invocation result in --here mode test
medhatgalal Feb 26, 2026
8779451
test: capture init result in here-mode command test
medhatgalal Feb 26, 2026
f28c4ce
chore: save local unapproved work in progress
medhatgalal Feb 28, 2026
d6d141b
fix: resolve remaining PR1690 review threads
medhatgalal Feb 28, 2026
c40ee63
Update src/specify_cli/__init__.py
mnriem Mar 3, 2026
a08070f
test: reduce brittleness in ai help alias assertion
medhatgalal Mar 3, 2026
8020794
fix: resolve PR1690 ruff syntax regression
medhatgalal Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: address PR feedback for kiro-cli migration
  • Loading branch information
@medhatgalal
medhatgalal committed Mar 3, 2026
commit bbfd0d003233a272ea884ebfe36021d4f256cb11
29 changes: 27 additions & 2 deletions .devcontainer/post-create.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,33 @@ echo "✅ Done"

echo -e "\n🤖 Installing Kiro CLI..."
# https://kiro.dev/docs/cli/
run_command "curl -fsSL https://cli.kiro.dev/install | bash"
run_command "kiro-cli --help > /dev/null"
KIRO_INSTALLER_URL="https://cli.kiro.dev/install"
KIRO_INSTALLER_PATH="$(mktemp)"

cleanup_kiro_installer() {
rm -f "$KIRO_INSTALLER_PATH"
}
trap cleanup_kiro_installer EXIT

run_command "curl -fsSL \"$KIRO_INSTALLER_URL\" -o \"$KIRO_INSTALLER_PATH\""

if [ -n "${KIRO_INSTALLER_SHA256:-}" ]; then
run_command "echo \"$KIRO_INSTALLER_SHA256 $KIRO_INSTALLER_PATH\" | sha256sum -c -"
fi

Comment thread
mnriem marked this conversation as resolved.
Outdated
run_command "bash \"$KIRO_INSTALLER_PATH\""

Comment thread
medhatgalal marked this conversation as resolved.
kiro_binary=""
if command -v kiro-cli >/dev/null 2>&1; then
kiro_binary="kiro-cli"
elif command -v kiro >/dev/null 2>&1; then
kiro_binary="kiro"
else
echo -e "\033[0;31m[ERROR] Kiro CLI installation did not create 'kiro-cli' or 'kiro' in PATH.\033[0m" >&2
exit 1
fi

run_command "$kiro_binary --help > /dev/null"
echo "✅ Done"

echo -e "\n🤖 Installing CodeBuddy CLI..."
Expand Down
4 changes: 3 additions & 1 deletion tests/test_ai_skills.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,9 @@ def fake_download(project_path, *args, **kwargs):
patch("specify_cli.install_ai_skills", return_value=True), \
patch("specify_cli.is_git_repo", return_value=True), \
patch("specify_cli.shutil.which", return_value="/usr/bin/git"):
runner.invoke(app, ["init", "--here", "--ai", "claude", "--ai-skills", "--script", "sh", "--no-git"])
result = runner.invoke(app, ["init", "--here", "--ai", "claude", "--ai-skills", "--script", "sh", "--force", "--no-git"])

assert result.exit_code == 0
# Commands must remain for --here
assert cmds_dir.exists()
assert (cmds_dir / "speckit.specify.md").exists()
Expand Down
8 changes: 3 additions & 5 deletions tests/test_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,11 +401,9 @@ class TestCommandRegistrar:

def test_kiro_cli_agent_config_present(self):
"""Kiro CLI should be mapped to .kiro/prompts and legacy q removed."""
registrar = CommandRegistrar()

assert "kiro-cli" in registrar.AGENT_CONFIGS
assert registrar.AGENT_CONFIGS["kiro-cli"]["dir"] == ".kiro/prompts"
assert "q" not in registrar.AGENT_CONFIGS
assert "kiro-cli" in CommandRegistrar.AGENT_CONFIGS
assert CommandRegistrar.AGENT_CONFIGS["kiro-cli"]["dir"] == ".kiro/prompts"
assert "q" not in CommandRegistrar.AGENT_CONFIGS

def test_parse_frontmatter_valid(self):
"""Test parsing valid YAML frontmatter."""
Expand Down