Skip to content

Pin GitHub Actions to commit SHAs #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fletchto99 merged 2 commits into from
Sep 11, 2026
+8 −7
Merged

Pin GitHub Actions to commit SHAs #600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c08420e
Pin GitHub Actions to commit SHAs
github-security-bot Sep 10, 2026
84d9619
Fix configuration spec linting on Ruby 2.7
fletchto99 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix configuration spec linting on Ruby 2.7 
Use RSpec's attribute matcher instead of dynamic public_send calls so the copy assertion no longer needs a suppression for a cop missing from older rubocop-github versions. Keep coverage of every copied attribute without relaxing lint enforcement.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@fletchto99
fletchto99 and Copilot committed Sep 10, 2026
commit 84d9619c7c82699012a843472b4ce312e04189cf
5 changes: 2 additions & 3 deletions spec/lib/secure_headers/configuration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ module SecureHeaders
configuration = Configuration.dup
expect(original_configuration).not_to be(configuration)
Configuration::CONFIG_ATTRIBUTES.each do |attr|
# rubocop:disable GitHub/AvoidObjectSendWithDynamicMethod
expect(original_configuration.public_send(attr)).to eq(configuration.public_send(attr))
# rubocop:enable GitHub/AvoidObjectSendWithDynamicMethod
expected_value = original_configuration.instance_variable_get("@#{attr}")
expect(configuration).to have_attributes(attr => expected_value)
end
end

Expand Down