Skip to content

Add test to exercise override opting out without default_src #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafaelfranca wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test to exercise override opting out without default_src #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add test to exercise override opting out without default_src 
On secure_headers 5.x it was possible to override the CSP directives
when optin out without having to define a default_src.

Now on 6.x it is required to set the default_src when overriding other
directives.

It is not clear in the CHANGELOG/upgrade guide if this change is by
design or if it is just a side effect of other changes.

I could not find anyting in the spec that says that default_src is
required or not, so I decided to open a PR with a test to get feedback
on that.

If this is undesirable behavior I'm willing to change this PR to fix the
problem.

Let me know what are the next steps.

Thanks.
  • Loading branch information
@rafaelfranca
rafaelfranca committed Aug 19, 2020
commit 91ded1afd0a50a1df526605417e3412c06472f8d
11 changes: 11 additions & 0 deletions spec/lib/secure_headers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,17 @@ module SecureHeaders
expect(hash[XFrameOptions::HEADER_NAME]).to eq(XFrameOptions::SAMEORIGIN)
end

it "allows you to override opting out without default_src" do
Configuration.default do |config|
config.csp = OPT_OUT
end

SecureHeaders.override_content_security_policy_directives(request, { frame_ancestors: %w('none') }, :enforced)

hash = SecureHeaders.header_hash_for(request)
expect(hash[ContentSecurityPolicyConfig::HEADER_NAME]).to eq("default-src https:; script-src 'self'")
end

it "produces a hash of headers with default config" do
Configuration.default
hash = SecureHeaders.header_hash_for(request)
Expand Down