Decide on pending cops - #484
Merged
Merged
Conversation
- Promote all pending cops into the default configuration based on their results against github/github and the Ruby styleguide. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Promote all Rails-specific pending cops into the Rails configuration based on their results against github/github. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All pending cops receive explicit decisions, and the related cleanup is consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Promotes pending RuboCop rules into explicit configurations, preventing unexpected defaults for consumers.
Changes:
- Explicitly enables or disables pending Ruby, performance, and Rails cops.
- Clears both pending-cop files.
- Removes an obsolete inline cop suppression.
| File | Description |
|---|---|
config/default.yml |
Records decisions for general cops. |
config/default_pending.yml |
Removes resolved pending cops. |
config/rails.yml |
Records decisions for Rails cops. |
config/rails_pending.yml |
Removes resolved pending cops. |
lib/rubocop/cop/github/rails_view_render_literal.rb |
Removes obsolete suppression directives. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
issyl0
enabled auto-merge
October 2, 2026 09:32
issyl0
force-pushed
the
decide-on-pending-cops
branch
from
October 2, 2026 09:46
136b479 to
e581980
Compare
mclark
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped a consumer of this gem to its latest version and it produced a bunch of offenses.
Turns out that, per the README, as part of bumping the RuboCop version I should have categorized and promoted the new rules, otherwise, all are enabled by default because the pending cops aren't inherited.